After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616019 - >=gnome-disk-utility-2.28.1 fails intltool tests
>=gnome-disk-utility-2.28.1 fails intltool tests
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2010-04-17 11:54 UTC by Pacho Ramos
Modified: 2010-09-16 10:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-disk-utility-2.28.1-fix-potfiles_skip.patch (284 bytes, patch)
2010-04-19 18:09 UTC, Pacho Ramos
none Details | Review

Description Pacho Ramos 2010-04-17 11:54:03 UTC
We get:
make[1]: Entering directory `/home/pacho/gnome-disk-utility-2.28.1/help'
xmllint --noout --noent --path C:./C --xinclude --postvalid ./C/palimpsest.xml
xmllint --noout --noent --path de:./de --xinclude --postvalid ./de/palimpsest.xml
xmllint --noout --noent --path el:./el --xinclude --postvalid ./el/palimpsest.xml
xmllint --noout --noent --path es:./es --xinclude --postvalid ./es/palimpsest.xml
xmllint --noout --noent --path pl:./pl --xinclude --postvalid ./pl/palimpsest.xml
xmllint --noout --noent --path pt_BR:./pt_BR --xinclude --postvalid ./pt_BR/palimpsest.xml
xmllint --noout --noent --path sv:./sv --xinclude --postvalid ./sv/palimpsest.xml
xmllint --noout --noent --path zh_CN:./zh_CN --xinclude --postvalid ./zh_CN/palimpsest.xml
xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' palimpsest-C.omf
xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' palimpsest-de.omf
xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' palimpsest-el.omf
xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' palimpsest-es.omf
xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' palimpsest-pl.omf
xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' palimpsest-pt_BR.omf
xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' palimpsest-sv.omf
xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' palimpsest-zh_CN.omf
make[1]: Leaving directory `/home/pacho/gnome-disk-utility-2.28.1/help'
Making check in po
make[1]: Entering directory `/home/pacho/gnome-disk-utility-2.28.1/po'
INTLTOOL_EXTRACT=/usr/bin/intltool-extract srcdir=. /usr/bin/intltool-update --gettext-package gnome-disk-utility --pot
rm -f missing notexist
srcdir=. /usr/bin/intltool-update -m
Invalid [] range "F-8" in regex; marked by <-- HERE in m/[encoding: UTF-8 <-- HERE ]
/ at /usr/bin/intltool-update line 321, <FILE> line 1.
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/pacho/gnome-disk-utility-2.28.1/po'
make: *** [check-recursive] Error 1


This is from the following downstream bug report but I have just reproduced it with upstream sources and manual compiling them
http://bugs.gentoo.org/show_bug.cgi?id=313351

Thanks for your help
Comment 1 Pacho Ramos 2010-04-19 18:09:22 UTC
Created attachment 159096 [details] [review]
gnome-disk-utility-2.28.1-fix-potfiles_skip.patch

"Encoding" doesn't have to be set in POTFILES.skip, that was the problem (and it also affects to master)
Comment 2 Nirbheek Chauhan 2010-09-16 01:23:23 UTC
This bug was resolved in http://git.gnome.org/browse/gnome-disk-utility/commit/?id=3fb339c1543f0b0eea388b4dadb8bcd05653d5ba

It should probably be closed as FIXED.
Comment 3 Pacho Ramos 2010-09-16 10:41:12 UTC
Thanks for noticing it