After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615613 - Use accessor functions instead direct access (use GSEAL GnomeGoal)
Use accessor functions instead direct access (use GSEAL GnomeGoal)
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.30.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
evolution[cleanup]
Depends on: 593671 596428 612509 615666
Blocks: 585391
 
 
Reported: 2010-04-13 05:28 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-06-14 17:37 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
Use accessor functions (41.77 KB, patch)
2010-04-13 05:30 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-04-13 05:28:32 UTC 
See http://live.gnome.org/GnomeGoals/UseGseal for more details
Comment 1 Javier Jardón (IRC: jjardon) 2010-04-13 05:30:10 UTC 
Created attachment 158573 [details] [review]
Use accessor functions

Still remaining (no GTK+ api):

GtkAccessible::widget
GtkAssistant::forward
GtkAssistant::back
GtkObject::flags
GtkTreeStore::stamp
Comment 2 Matthew Barnes 2010-04-13 12:03:32 UTC 
Thanks for this!  Please commit.

The GtkAssistant fields are related to bug #596428.  We don't need accessor functions so much as the enhancement described there implemented.  Planning to take a shot at it myself when I find time, unless someone beats me to it.
Comment 3 Javier Jardón (IRC: jjardon) 2010-04-13 14:25:25 UTC 
Comment on attachment 158573 [details] [review]
Use accessor functions

commit 96421ff37cd554af1ac11527bcad25cc2f2f1930

Thank you for the review!
Comment 4 Tobias Mueller 2010-04-14 01:07:41 UTC 
Hm. Can this bug be closed then? :)
Comment 5 Matthew Barnes 2010-04-14 02:27:23 UTC 
Best leave it open for tracking purposes until we can actually build with GSEAL_ENABLE.  This bug blocks bug #585391.
Comment 6 Matthew Barnes 2010-06-04 12:37:13 UTC 
Status update:

The GtkAccessible issue is fixed by using the new gtk_accessible_get_widget() function in GTK+ 2.21.

The GtkAssistant issues are fixed by using the new gtk_assistant_commit() function in GTK+ 2.21.

I just commented out with a FIXME message the one place in the "groupwise-features" plugin where it's referencing GtkTreeStore::stamp.

GnomeCanvasItem adds its own flags to GtkObject::flags which we still have to check in plenty of places, so that's still an issue.  GnomeCanvasItem could just as easily add its own flags member, but that would be an API + ABI break.
Comment 7 Matthew Barnes 2010-06-14 17:37:07 UTC 
We now bundle libgnomecanvas in libart_lgpl in Evolution, and I gave GnomeCanvasItem its own flags field.  So all issues are now solved.  Closing as FIXED.