After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615460 - [deinterlace] broken ...
[deinterlace] broken ...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal critical
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-11 17:39 UTC by Edward Hervey
Modified: 2010-04-11 20:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Edward Hervey 2010-04-11 17:39:10 UTC 
Just realized the deinterlacer broken since it was moved from bad/deinterlace2.

Just run it on any DV file (or any interlaced content for that matter) and watch it output crap.

gstdeinterlace.c:938:gst_deinterlace_push_history:<deinterlace0> Can't detect field layout -- assuming TFF

I'm guessing it's related to that.
Comment 1 David Schleef 2010-04-11 19:36:23 UTC 
I'm guessing that too, since it works correctly with ewdvdec, which outputs interlacing and field flags correctly.
Comment 2 David Schleef 2010-04-11 20:11:51 UTC 
Oops, no, I was wrong about that.  They both provide the same (correct) buffer flags, but deinterlace defaults to tff=auto and detects the stream incorrectly.

Patch shortly.
Comment 3 David Schleef 2010-04-11 20:17:40 UTC 
By the way, deinterlace could use some love to negotiate whether or not to deinterlace based on the caps instead of using a property.


commit 289f69eb84148d3c92665c76d8730de6fd7cca3d
Author: David Schleef <ds@schleef.org>
Date:   Sun Apr 11 13:14:30 2010 -0700

    deinterlace: Only check interlaced flag in sink caps
    
    Fixes #615460.