After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615130 - Modernize autotools configuration
Modernize autotools configuration
Status: RESOLVED FIXED
Product: gnome-nettool
Classification: Applications
Component: general
2.30.x
Other All
: Normal normal
: ---
Assigned To: Germán Poo-Caamaño
Rodrigo Moya
Depends on:
Blocks:
 
 
Reported: 2010-04-08 02:27 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-04-08 03:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Modernize autotools configuration (7.51 KB, patch)
2010-04-08 02:57 UTC, Javier Jardón (IRC: jjardon) 		accepted-commit_now Details | Review
Modernize autotools configuration.v2 (7.46 KB, patch)
2010-04-08 03:01 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-04-08 02:27:35 UTC 
See http://live.gnome.org/GnomeGoals/ModernAutotools
Comment 1 Javier Jardón (IRC: jjardon) 2010-04-08 02:57:18 UTC 
Created attachment 158160 [details] [review]
Modernize autotools configuration
Comment 2 Javier Jardón (IRC: jjardon) 2010-04-08 03:01:35 UTC 
Created attachment 158161 [details] [review]
Modernize autotools configuration.v2

Fix commit message
Comment 3 Germán Poo-Caamaño 2010-04-08 03:02:36 UTC 
Review of attachment 158160 [details] [review]:

It seems the commit's comment should not have the following line:

"Also, move GtkBuilder and .desktop files to data directory."

Please fix it and then, commit it.

Thanks.
Comment 4 Germán Poo-Caamaño 2010-04-08 03:04:12 UTC 
Review of attachment 158161 [details] [review]:

Please, commit it.  Thanks!
Comment 5 Javier Jardón (IRC: jjardon) 2010-04-08 03:06:43 UTC 
Comment on attachment 158161 [details] [review]
Modernize autotools configuration.v2

commit cd5b7982db09cd67e1f25509b77f1a1dfbbafa14
Comment 6 Javier Jardón (IRC: jjardon) 2010-04-08 03:07:05 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thank you for the review!