After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615002 - Cheese crashes if you press take a photo and you have no webcam
Cheese crashes if you press take a photo and you have no webcam
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
2.30.x
Other Linux
: Normal normal
: 2.28
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-04-06 19:54 UTC by Ben
Modified: 2010-04-22 06:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
backtrace (8.09 KB, application/octet-stream)
2010-04-06 20:53 UTC, Ben 		  Details
backtrace (8.09 KB, text/plain)
2010-04-06 20:54 UTC, Ben 		  Details
Disables 'Take Photo' menu item when no devices are found (984 bytes, patch)
2010-04-08 20:18 UTC, Yuvi 		committed Details | Review
menu: disable Take Photo when there is no camera (969 bytes, patch)
2010-04-22 06:35 UTC, Filippo Argiolas 		committed Details | Review

Description Ben 2010-04-06 19:54:12 UTC 
to reproduce:
1. do not have a camera attached
2. go to File>take a photo
3. watch cheese crash
Comment 1 Ben 2010-04-06 20:53:22 UTC 
Created attachment 158080 [details]
backtrace
Comment 2 Ben 2010-04-06 20:54:42 UTC 
Created attachment 158081 [details]
backtrace
Comment 3 Ben 2010-04-06 20:56:01 UTC 
hmmm sorry I did not add the .txt extension to the first attachment and i do not see a way to delete it. Just ignore it and use the second one.
Comment 4 Ben 2010-04-06 21:31:17 UTC 
https://bugs.launchpad.net/ubuntu/+source/cheese/+bug/556610, this is the downstream bug I am forwarding.

Obviously the menu item just needs to be greyed out, but the code should have some error handling to if it is not to difficult, that is why I included the backtrace.
Comment 5 Yuvi 2010-04-08 20:18:08 UTC 
Created attachment 158235 [details] [review]
Disables 'Take Photo' menu item when no devices are found
Comment 6 Filippo Argiolas 2010-04-22 06:34:53 UTC 
The following fix has been pushed:
fba6148 menu: disable Take Photo when there is no camera
Comment 7 Filippo Argiolas 2010-04-22 06:35:00 UTC 
Created attachment 159311 [details] [review]
menu: disable Take Photo when there is no camera
Comment 8 Filippo Argiolas 2010-04-22 06:36:37 UTC 
Yuvi, I had to manually fix the author name in the patch. Please fix your .gitconfig!