GNOME Bugzilla – Bug 614913
gnome-volume-control doesn't use the right icon
Last modified: 2010-04-15 14:18:40 UTC
It should use the icon name "multimedia-volume-control" and rename the fallback icons that it ships accordingly.
Created attachment 158355 [details] [review] Use proper icon.
Seems like it already uses the multimedia-volume-control properly. grep -R "gnome-volume-control" * data/Makefile.am:autostart_in_files = gnome-volume-control-applet.desktop.in data/Makefile.am:apps_in_files = gnome-volume-control.desktop.in data/Makefile.am: gnome-volume-control.desktop.in.in \ data/Makefile.am: gnome-volume-control.desktop \ data/Makefile.am: gnome-volume-control-applet.desktop \ data/gnome-volume-control.desktop.in.in:Exec=gnome-volume-control data/gnome-volume-control.desktop.in.in:Icon=gnome-volume-control data/gnome-volume-control.desktop.in.in:X-GNOME-Bugzilla-Component=gnome-volume-control data/icons/16x16/apps/Makefile.am: gnome-volume-control.png \ data/icons/16x16/apps/Makefile.am: gnome-volume-control.svg data/icons/48x48/apps/Makefile.am: gnome-volume-control.png \ data/icons/22x22/apps/Makefile.am: gnome-volume-control.png \ data/icons/22x22/apps/Makefile.am: gnome-volume-control.svg data/icons/scalable/apps/Makefile.am: gnome-volume-control.svg \ data/icons/24x24/apps/Makefile.am: gnome-volume-control.png \ data/icons/32x32/apps/Makefile.am: gnome-volume-control.png \ data/icons/32x32/apps/Makefile.am: gnome-volume-control.svg data/gnome-volume-control-applet.desktop.in:Exec=gnome-volume-control-applet data/gnome-volume-control-applet.desktop.in:X-GNOME-Bugzilla-Component=gnome-volume-control src/gvc-stream-status-icon.c: "gnome-volume-control", src/Makefile.am: gnome-volume-control-applet \ src/Makefile.am: gnome-volume-control \ This patch only changes the Icon entry in the gnome-volume-control.desktop.in.in file.
(In reply to comment #2) > Seems like it already uses the multimedia-volume-control properly. > > grep -R "gnome-volume-control" * How do you mean? Why are you grepping for gnome-volume-control?
I was checking where the icon `gnome-volume-control` was used, and it appears that is it not used and that gnome-volume-control already uses the multimedia-volume-control icon. But maybe I misunderstood the bug report, sorry in that case.
(In reply to comment #4) > I was checking where the icon `gnome-volume-control` was used, and it appears > that is it not used and that gnome-volume-control already uses the > multimedia-volume-control icon. But maybe I misunderstood the bug report, sorry > in that case. Maybe I wasn't very clear. Your patch does the right thing. Now all the icon files will need to be renamed to "multimedia-volume-control" as well. Same as all references to it in the source code and make files. That's the stuff you already grepped. :)
data/Makefile.am:autostart_in_files = gnome-volume-control-applet.desktop.in data/Makefile.am:apps_in_files = gnome-volume-control.desktop.in data/Makefile.am: gnome-volume-control.desktop.in.in \ data/Makefile.am: gnome-volume-control.desktop \ data/Makefile.am: gnome-volume-control-applet.desktop \ data/gnome-volume-control.desktop.in.in:Exec=gnome-volume-control data/gnome-volume-control.desktop.in.in:Icon=gnome-volume-control data/gnome-volume-control.desktop.in.in:X-GNOME-Bugzilla-Component=gnome-volume-control These should probably not be renamed though.
Actually, could you enlighten me on the icon mechanism ? Why are the gnome-volume-control.(png|svg) shipped ? My guess was that the program tries to use the multimedia-volume-control icon from the stock, and if it isn't available, it falls back to gnome-volume-control icon ?
(In reply to comment #7) > Actually, could you enlighten me on the icon mechanism ? Why are the > gnome-volume-control.(png|svg) shipped ? My guess was that the program tries to > use the multimedia-volume-control icon from the stock, and if it isn't > available, it falls back to gnome-volume-control icon ? You are right. We ship a multimedia-volume control icon in gnome-icon-theme because it is in the naming spec, so that should be used. However, when a user chooses to use a different theme that won't have that icon available it should fall back to the icon provided by the gnome-volume-control package. For this to happen they need to have the same names.
Created attachment 158365 [details] [review] Use multimedia-volume-control icon. Thanks ! This patch renames all the icons and edit the Makefiles as well, plus the previous patch. I think that's all needed.