Bug 614842 – [jpegenc] sink pad returns ANY (not subset of its template) when connected to a filesink

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 614842 - [jpegenc] sink pad returns ANY (not subset of its template) when connected to a filesink


Summary:	[jpegenc] sink pad returns ANY (not subset of its template) when connected to...


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-good
Version:	git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	0.10.22
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2010-04-04 23:30 UTC by André Dieb Martins
Modified:	2010-04-05 00:43 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Proposed fix (1.04 KB, patch) 2010-04-04 23:32 UTC, André Dieb Martins	committed	Details \| Review

Description André Dieb Martins 2010-04-04 23:30:41 UTC

Triggering:

GST_DEBUG=*:2 gst-launch videotestsrc num-buffers=1 ! ffmpegcolorspace ! "video/x-raw-rgb" ! ffmpegcolorspace ! jpegenc ! filesink location=/tmp/test.jpg

Problem output:
0:00:01.019331021 10654  0x90418d0 ERROR               GST_CAPS gstpad.c:2155:gst_pad_get_caps_unlocked:<jpegenc0:sink> pad returned caps ANY which are not a real subset of its template caps video/x-raw-yuv, format=(fourcc)I420, width=(int)[ 1, 2147483647 ], height=(int)[ 1, 2147483647 ], framerate=(fraction)[ 0/1, 2147483647/1 ]
(gst-launch-0.10:10654): GStreamer-WARNING **: pad jpegenc0:sink returned caps which are not a real subset of its template caps

Comment 1 André Dieb Martins 2010-04-04 23:32:24 UTC

Created attachment 157930 [details] [review]
Proposed fix

Comment 2 Thiago Sousa Santos 2010-04-05 00:42:01 UTC

Thanks for the fix, pushed it.

Module: gst-plugins-good
Branch: master
Commit: 74ac172bc20e1ae657484aeb37fbaf08ad2a2b28
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=74ac172bc20e1ae657484aeb37fbaf08ad2a2b28

Author: André Dieb Martins <andre.dieb@gmail.com>
Date:   Sun Apr  4 20:31:38 2010 -0300

jpegenc: should not return caps ANY based on downstream

When downstream has a sink pad with ANY caps, jpegenc should
treat it the same as NULL and return its template caps.

Fixes #614842