After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614512 - Use gtk_widget_set_visible() to substitute GTK_WIDGET_SET_FLAGS (widget, VISIBLE) breaks the tests
Use gtk_widget_set_visible() to substitute GTK_WIDGET_SET_FLAGS (widget, VISI...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.20.x
Other All
: Normal blocker
: 3.0
Assigned To: gtk-bugs
gtk-bugs
Depends on: 615666
Blocks: 69872
 
 
Reported: 2010-03-31 21:30 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-10-15 01:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Deprecate GTK_VISIBLE (4.73 KB, patch)
2010-03-31 21:30 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-03-31 21:30:30 UTC 
Created attachment 157640 [details] [review]
Deprecate GTK_VISIBLE

Patch applied attached


TEST: testing... (pid=9910)
  /ui-tests/text-access:                                               OK
  /ui-tests/button-clicks:                                             
GLib-GObject-CRITICAL **: g_closure_ref: assertion `closure->ref_count < CLOSURE_MAX_REF_COUNT' failed
aborting...
FAIL
GTester: last random seed: R02Sd9a5804004d0f92326bfcdc25674bf09
Terminado
make[2]: *** [test] Error 143
Comment 1 Emmanuele Bassi (:ebassi) 2010-04-26 18:07:37 UTC 
Review of attachment 157640 [details] [review]:

::: gtk/gtkwidget.c
@@ +3193,3 @@
     {
   if (!gtk_widget_get_visible (widget))
+      GTK_OBJECT_FLAGS (widget) |= GTK_VISIBLE;

why are you using GTK_OBJECT_FLAGS here?
Comment 2 Emmanuele Bassi (:ebassi) 2010-04-26 18:07:38 UTC 
Review of attachment 157640 [details] [review]:

::: gtk/gtkwidget.c
@@ +3193,3 @@
     {
   if (!gtk_widget_get_visible (widget))
+      GTK_OBJECT_FLAGS (widget) |= GTK_VISIBLE;

why are you using GTK_OBJECT_FLAGS here?
Comment 3 Javier Jardón (IRC: jjardon) 2010-05-27 18:12:34 UTC 
@Emmanuele:

Because GTK_WIDGET_SET_FLAGS() is deprecated
Comment 4 Matthias Clasen 2010-09-19 05:39:23 UTC 
This is covered by the gtkobject-removal branch which gets rid of all GtkWidgetFlags
Comment 5 Javier Jardón (IRC: jjardon) 2010-10-15 01:32:03 UTC 
This is fixed now