After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614185 - g_type_class_add_private() documentation is not correct
g_type_class_add_private() documentation is not correct
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: docs
2.24.x
Other All
: Normal major
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-03-28 16:07 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-03-29 16:18 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30

Attachments
Fix g_type_class_add_private() (2.16 KB, patch)
2010-03-28 16:12 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Re-introduce example for g_type_class_add_private and fix Since (1.53 KB, patch)
2010-03-29 14:14 UTC, Christian Dywan 		none Details | Review

Description Javier Jardón (IRC: jjardon) 2010-03-28 16:07:53 UTC 
Patch following
Comment 1 Javier Jardón (IRC: jjardon) 2010-03-28 16:12:10 UTC 
Created attachment 157327 [details] [review]
Fix g_type_class_add_private()
Comment 2 Christian Dywan 2010-03-28 19:09:43 UTC 
Apparently fixed in master.
Comment 3 Javier Jardón (IRC: jjardon) 2010-03-28 20:09:51 UTC 
No, It's no fixed. Note that commit 81e2aa941bbfd02bf1b6235da12834d282ceda0c introduced the incorrect change.
Comment 4 Christian Dywan 2010-03-28 23:57:18 UTC 
My apologies. This definitely needs to be fixed in the next stable.
Comment 5 Matthias Clasen 2010-03-29 12:51:49 UTC 
No. I removed that example for a reason. Look at it, it is just wrong.
Comment 6 Christian Dywan 2010-03-29 14:14:57 UTC 
Created attachment 157380 [details] [review]
Re-introduce example for g_type_class_add_private and fix Since

My apologies, Matthias, I had thought the above patched fixed the example but it isn't complete. Attached is an updated patch. I also added a sentence to stress the use of a priv pointer.

Note the Since: 2.24 also has to be corrected to say Since 2.4 again, as done in the patch.
Comment 7 Javier Jardón (IRC: jjardon) 2010-03-29 16:18:09 UTC 
Comment on attachment 157327 [details] [review]
Fix g_type_class_add_private()

commit 0f51e995658a50dbecb74b006f05a1ea69f43558
Comment 8 Javier Jardón (IRC: jjardon) 2010-03-29 16:18:49 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release.