After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614047 - StBoxLayout: remove an incorrect drawing optimization
StBoxLayout: remove an incorrect drawing optimization
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-26 19:23 UTC by Dan Winship
Modified: 2010-03-29 18:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
StBoxLayout: remove an incorrect drawing optimization (3.03 KB, patch)
2010-03-26 19:23 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2010-03-26 19:23:06 UTC
Paint/pick all children, regardless of whether or not they lie within
the content_box. The previous behavior was that a child that was 99%
outside the box would be fully visible, but a child that was 100%
outside the box would be fully hidden. This is somewhat odd, and
doesn't match the behavior of the other St container classes, and at
any rate, the use of clutter_actor_get_allocation_box() for this
optimization was incorrect since it doesn't take into account
transformations (anchor point, rotation, etc) that might cause the
child to be drawn within the content_box anyway.

(For scrolled StBoxLayouts, drawing is still clipped to the
content_box, as before, but will now properly take transformations
into account as well.)
Comment 1 Dan Winship 2010-03-26 19:23:08 UTC
Created attachment 157207 [details] [review]
StBoxLayout: remove an incorrect drawing optimization
Comment 2 Colin Walters 2010-03-26 20:51:43 UTC
Review of attachment 157207 [details] [review]:

This looks sane to me; but I wonder why the check was introduced at all?
Comment 3 Dan Winship 2010-03-29 18:38:32 UTC
Attachment 157207 [details] pushed as 1dd4c71 - StBoxLayout: remove an incorrect drawing optimization