After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614037 - flacparse: Fix buffer refcount issue
flacparse: Fix buffer refcount issue
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-26 16:56 UTC by Arun Raghavan
Modified: 2010-03-26 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flacparse: Fix buffer refcount issue (1022 bytes, patch)
2010-03-26 16:56 UTC, Arun Raghavan 		committed Details | Review

Description Arun Raghavan 2010-03-26 16:56:53 UTC 
There is a small bug in flacparse with setting caps on a buffer with refcount > 1. Attaching a patch to fix this.
Comment 1 Arun Raghavan 2010-03-26 16:56:55 UTC 
Created attachment 157196 [details] [review]
flacparse: Fix buffer refcount issue

When called from the GST_FLAC_PARSE_STATE_HEADERS case,
gst_flac_parse_hand_headers() does a gst_buffer_set_caps() on a buffer
with refcount > 1. This change handles this case by making the buffer
metadata_Writable.
Comment 2 Sebastian Dröge (slomo) 2010-03-26 17:15:08 UTC 
commit cc6c4ef00b73c9b8b468d2ad1cfadf64e896b068
Author: Arun Raghavan <arun.raghavan@collabora.co.uk>
Date:   Fri Mar 26 16:49:01 2010 +0000

    flacparse: Fix buffer refcount issue
    
    When called from the GST_FLAC_PARSE_STATE_HEADERS case,
    gst_flac_parse_hand_headers() does a gst_buffer_set_caps() on a buffer
    with refcount > 1. This change handles this case by making the buffer
    metadata_Writable.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=614037