After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613353 - AccelLabel set_accel_widget() allow NULL
AccelLabel set_accel_widget() allow NULL
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2010-03-19 18:51 UTC by Kevin Ryde
Modified: 2010-03-31 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
accept undef in set_accel_widget() (1.59 KB, patch)
2010-03-19 18:51 UTC, Kevin Ryde 		committed Details | Review

Description Kevin Ryde 2010-03-19 18:51:24 UTC 
Created attachment 156576 [details] [review]
accept undef in set_accel_widget()

I believe $accel_label->set_accel_widget can accept NULL for when there's no target widget. (Which is its default setting too I think.)

Perhaps an _ornull per below.  Should get_accel_widget have an _ornull on its return similarly?  Or plain GtkWidget typemap already allows NULL in a return, so it doesn't matter ...

The tedium of individually wrapped get/set_foo funcs, eh :-)
Comment 1 Torsten Schoenfeld 2010-03-31 16:57:04 UTC 
Thanks, committed.

The _ornull on the getter is not stricly necessary since the outgoing typemap
handles NULL gracefully.  But when the doc generator sees the _ornull, it turns
it into "or undef" in the POD signature, which is useful.