After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613002 - [flvmux] always put duration in metadata tag
[flvmux] always put duration in metadata tag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-16 00:34 UTC by Jan Urbański
Modified: 2010-03-16 14:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Cleanup unused structure field. (2.14 KB, patch)
2010-03-16 00:34 UTC, Jan Urbański 		committed Details | Review
Always put duration tag in metadata (7.21 KB, patch)
2010-03-16 00:35 UTC, Jan Urbański 		committed Details | Review

Description Jan Urbański 2010-03-16 00:34:10 UTC 
Some Flash players (for instance JW Player: http://www.longtailvideo.com/players/jw-flv-player/) always expect a duration tag, otherwise they don't start playback.

Sample pipeline that produced a file unplayable with JW Player:

gst-launch videotestsrc num-buffers=500 ! x264enc ! flvmux name=mux audiotestsrc num-buffers=500 ! lame ! mux. mux. ! filesink location=out.flv
Comment 1 Jan Urbański 2010-03-16 00:34:56 UTC 
Created attachment 156239 [details] [review]
Cleanup unused structure field.
Comment 2 Jan Urbański 2010-03-16 00:35:16 UTC 
Created attachment 156240 [details] [review]
Always put duration tag in metadata
Comment 3 Sebastian Dröge (slomo) 2010-03-16 14:11:53 UTC 
commit ef20ad3f5dce8511d4c248f523cc6525575d9e93
Author: Jan Urbański <wulczer@wulczer.org>
Date:   Tue Mar 16 01:29:36 2010 +0100

    flvmux: Always put a duration tag in the metadata
    
    Some Flash players (for instance JW Player) always expect a duration
    tag, otherwise they don't start playback.
    
    If duration can be queried from the sink pads or is provided as a tag,
    use it. Otherwise try to determine it from the last seen timestamp of
    the sink pads after EOS and rewrite it in the header before writing
    the index.

commit db2147076dc4845c735e20144ca0e99b339090f3
Author: Jan Urbański <wulczer@wulczer.org>
Date:   Tue Mar 16 00:35:46 2010 +0100

    flvmux: Remove the send_codec_data field from GstFlvPad
    
    That field is not used anymore after the changes in
    9fdecbc1c11f4e5af6578bba32a9b32771029d33.