After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612777 - Deprecated macro in gstspeexdec.c causes compile error in MSVC
Deprecated macro in gstspeexdec.c causes compile error in MSVC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.21
Other Windows
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-13 09:30 UTC by David Hoyt
Modified: 2010-03-15 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstspeexdec.c patch (555 bytes, patch)
2010-03-13 09:30 UTC, David Hoyt 		rejected Details | Review

Description David Hoyt 2010-03-13 09:30:46 UTC 
Created attachment 156050 [details] [review]
gstspeexdec.c patch

Compiling gstspeex with MSVC fails on line 541. According to the speex headers, SPEEX_STEREO_STATE_INIT is deprecated anyway. The provided patch resolves the issue by using the suggested speex_stereo_state_init() function.

It is, however, untested at this point. But the compile succeeds.
Comment 1 Sebastian Dröge (slomo) 2010-03-15 13:12:51 UTC 
Comment on attachment 156050 [details] [review]
gstspeexdec.c patch

The speex stereo state has to be freed afterwards when getting it with speex_stereo_state_init()
Comment 2 Sebastian Dröge (slomo) 2010-03-15 13:17:46 UTC 
commit fdc7b73675d9c135813971efce8cf084ef1cb114
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Mon Mar 15 14:16:58 2010 +0100

    speexdec: Use speex_stereo_state_init() instead of the deprecated initializa
    
    Fixes bug #612777.