After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612152 - File Location field is not uri-escaped correctly
File Location field is not uri-escaped correctly
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Smart Playlists
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-08 04:23 UTC by Andrés G. Aragoneses (IRC: knocte)
Modified: 2010-03-08 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch v1 (5.62 KB, patch)
2010-03-08 04:23 UTC, Andrés G. Aragoneses (IRC: knocte) 		none Details | Review
Patch v2 (5.62 KB, patch)
2010-03-08 04:25 UTC, Andrés G. Aragoneses (IRC: knocte) 		none Details | Review
file lacking in patch v2 (1.38 KB, text/plain)
2010-03-08 04:28 UTC, Andrés G. Aragoneses (IRC: knocte) 		  Details
Patch v3 (1.69 KB, patch)
2010-03-08 08:29 UTC, Andrés G. Aragoneses (IRC: knocte) 		none Details | Review
Patch v4 (7.97 KB, patch)
2010-03-08 09:55 UTC, Andrés G. Aragoneses (IRC: knocte) 		committed Details | Review

Description Andrés G. Aragoneses (IRC: knocte) 2010-03-08 04:23:29 UTC 
Created attachment 155522 [details] [review]
Patch v1

Steps to reproduce:
1. Import a file from a folder that contains a space (such as "PopRock II").
2. Create a Smart playlist with the condition FileLocation contains "PopRock II"

Current results:
It doesn't work.

Expected results:
The smartplaylist should contain the file.

Also explained by a user here:
http://mail.gnome.org/archives/banshee-list/2010-March/msg00061.html
Comment 1 Andrés G. Aragoneses (IRC: knocte) 2010-03-08 04:25:04 UTC 
Created attachment 155523 [details] [review]
Patch v2

Bug no. was incorrect.
Comment 2 Andrés G. Aragoneses (IRC: knocte) 2010-03-08 04:28:53 UTC 
Created attachment 155524 [details]
file lacking in patch v2

I don't know why this file is not included in the diff generated by git diff. It should be placed here:

./src/Libraries/Hyena/Hyena.Query/ExactUriStringQueryValue.cs
Comment 3 Andrés G. Aragoneses (IRC: knocte) 2010-03-08 08:29:10 UTC 
Created attachment 155529 [details] [review]
Patch v3

Now the new file is included.
Comment 4 Andrés G. Aragoneses (IRC: knocte) 2010-03-08 08:29:53 UTC 
Gosh, it didn't do it. I'll regen it asap.
Comment 5 Andrés G. Aragoneses (IRC: knocte) 2010-03-08 09:55:27 UTC 
Created attachment 155537 [details] [review]
Patch v4

Finally!
Comment 6 Alexander Kojevnikov 2010-03-08 10:36:24 UTC 
Committed, thanks Andrés!

commit f1d295d2b05a13b24e900ceb6392ce32568d691f
Author: Andrés G. Aragoneses <knocte@gmail.com>
Date:   Mon Mar 8 21:33:45 2010 +1100

    [Hyena.Query] Fix file location queries (bgo#612152)
    
    Signed-off-by: Alexander Kojevnikov <alexander@kojevnikov.com>