GNOME Bugzilla – Bug 612018
notificationDaemon.js is missing import
Last modified: 2010-03-08 21:02:25 UTC
diff --git a/js/ui/notificationDaemon.js b/js/ui/notificationDaemon.js index 0183962..c3cb270 100644 --- a/js/ui/notificationDaemon.js +++ b/js/ui/notificationDaemon.js @@ -5,6 +5,7 @@ const GLib = imports.gi.GLib; const Lang = imports.lang; const Shell = imports.gi.Shell; const Mainloop = imports.mainloop; +const St = imports.gi.St; const Main = imports.ui.main; const MessageTray = imports.ui.messageTray
I can confirm this is a bug and that the above patch fixes the problem. I was getting errors about St not being defined.
*** Bug 612027 has been marked as a duplicate of this bug. ***
Thanks for the catch - can you create a proper attachment with "git format-patch"? That's a lot easier to handle than an inlined diff, and it will make sure that you keep the credits!
(In reply to comment #3) > Thanks for the catch - can you create a proper attachment with "git > format-patch"? That's a lot easier to handle than an inlined diff, and it will > make sure that you keep the credits! And it will make sure that others find it easier and not create a new patch (duplicate work). (Didn't find yours while searching for patches).
Created attachment 155558 [details] [review] add missing import to notificationDaemon.js well, it's such a simple fix that applying a patch is more work than looking up the file and fixing this. anyway, here you go ..
(In reply to comment #5) > well, it's such a simple fix that applying a patch is more work than looking up > the file and fixing this. You should have a look at git-bz ;)
(In reply to comment #6) > You should have a look at git-bz ;) wow, nice .. thx