After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611998 - Do not use constant in gettext expressions
Do not use constant in gettext expressions
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.29.x
Other Linux
: Normal critical
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-06 15:15 UTC by Claude Paroz
Modified: 2010-03-15 08:15 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Claude Paroz 2010-03-06 15:15:01 UTC
In empathy-accounts.c, the following line is wrong (the constant is not expanded prior to gettext parsing):
g_set_application_name (_(PACKAGE_NAME " Accounts"));

You should instead use a printf syntax, something like:
g_set_application_name(g_strdup_printf(_("%s Accounts), PACKAGE_NAME))

Warning: we are now in string-freeze period :-)
Comment 1 André Klapper 2010-03-07 18:44:04 UTC
I expect this to be quite visible, hence critical.
Comment 2 Guillaume Desmottes 2010-03-08 09:21:16 UTC
This is actualy fixed in http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/separate-debug-window for which I requested an exception [1] 5 days ago but still didn't get approval...

[1] http://mail.gnome.org/archives/release-team/2010-March/msg00013.html
Comment 3 André Klapper 2010-03-08 09:32:00 UTC
(In reply to comment #2)
> This is actualy fixed in
> http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/separate-debug-window
> for which I requested an exception [1] 5 days ago but still didn't get
> approval...

Well, you received an answer which said to revert your previous freeze breaks first in http://mail.gnome.org/archives/release-team/2010-March/msg00027.html , then you asked if they could be let in in http://mail.gnome.org/archives/release-team/2010-March/msg00041.html .

Probably best to send another message summarizing all your requests.
Comment 4 Guillaume Desmottes 2010-03-15 08:15:49 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.