After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611930 - Symbol versioning not being applied
Symbol versioning not being applied
Status: RESOLVED FIXED
Product: gtk-vnc
Classification: Other
Component: general
0.3.x
Other Linux
: Normal major
: ---
Assigned To: gtk-vnc-maint
gtk-vnc-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-05 18:20 UTC by Guido Günther
Modified: 2010-03-20 17:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix symbol versioning (920 bytes, patch)
2010-03-05 18:20 UTC, Guido Günther 		none Details | Review
Add symbols mssing from symbils file. (738 bytes, patch)
2010-03-05 22:38 UTC, Guido Günther 		none Details | Review

Description Guido Günther 2010-03-05 18:20:11 UTC 
Created attachment 155345 [details] [review]
Fix symbol versioning

while working on the Debian package I noticed that symbol versioning
doesn't actually get applied. The reason is an extra space after -Wl.

Removing it makes libtool keep the -Wl,--version-script=... option and
pass it on to ld.
Comment 1 Guido Günther 2010-03-05 22:38:16 UTC 
Created attachment 155374 [details] [review]
Add symbols mssing from symbils file.

Attached patch adds

vnc_display_get_option_entries
vnc_display_set_depth
vnc_display_get_depth
vnc_display_depth_color_get_type
vnc_display_request_update

which are yet missing from the symbols file.
Comment 2 Guido Günther 2010-03-20 16:31:31 UTC 
Any plans to fix this?
Comment 3 Daniel P. Berrange 2010-03-20 17:53:09 UTC 
Sorry for the delay, I've applied both these fixes


commit 03416ba9505a941e252756fbe17927e0bc08ab65
Author: Guido Günther <agx@sigxcpu.org>
Date:   Sat Mar 20 17:50:54 2010 +0000

    Fix symbol versioning script application
    
    * src/Makefile.am: Drop space after -Wl, in libgtk_vnc_1_0_la_LDFLAGS
      to ensure linker script is applied

commit 07e52c8a6074c760924a3fbd78ce30228a4a9180
Author: Guido Günther <agx@sigxcpu.org>
Date:   Sat Mar 20 17:50:07 2010 +0000

    Add missing symbols
    
    * src/libgtk-vnc_sym.version: Add missing symbols from 0.3.8
      and 0.3.9 releases