Created attachment 155278 [details]
Crash log with debugging on

Short version:

There's an errant comma before the LIMIT clause of some (most?) smart playlists.  It causes Banshee to crash when the user tries to view the playlist, or, at least in the case of the playlist below, to crash when a song finishes playing and the playlist is auto-updated.


The basic details:

[Debug 21:50:14.664] Exception executing command: DELETE FROM CoreSmartPlaylistE
ntries WHERE SmartPlaylistID = 17;
                  INSERT INTO CoreSmartPlaylistEntries
                    (EntryID, SmartPlaylistID, TrackID)
                    SELECT NULL, 17 as SmartPlaylistID, TrackId FROM CoreTracks,
CoreAlbums,CoreArtists
                        WHERE CoreArtists.ArtistID = CoreTracks.ArtistID AND Cor
eAlbums.AlbumID = CoreTracks.AlbumID AND CoreTracks.PrimarySourceID = 1
                        AND ((CoreTracks.LastPlayedStamp > 1267753810 AND CoreTr
acks.LastPlayedStamp IS NOT NULL)) ORDER BY CoreTracks.LastPlayedStamp DESC,  LI
MIT 25
Mono.Data.Sqlite.SqliteException: Sqlite error
near "LIMIT": syntax error
  at Mono.Data.Sqlite.Sqlite3.Prepare (System.String strSql, Mono.Data.Sqlite.Sq
liteStatement previous, System.String& strRemain) [0x00000]


sqlite> select * from CoreSmartPlaylists where SmartPlaylistId=17;
1|17|Just Played|<request><query banshee-version="1"><lessThan><field name="lastplayed" /><date factor="Hour" type="rel">-3600</date></lessThan></query></request>|LastPlayedStamp-DESC|25|songs|3|0


An entire debug log is attached.  Feel free to ask me questions about this issue.  I'd love a way to fix it sans killing all my smart playlists with limits...