Created attachment 159886 [details] [review]
[MessageTray] fix clutter warnings

Figure out if the banner is too long to fit as soon as the
notification's style is set, rather than waiting until allocation
time, since it's bad to add new table rows during allocation.

(This is needed for the pre-expansion fix because otherwise we haven't
figured out that the notification is going to need to expand yet from
_showNotification().)

Created attachment 159887 [details] [review]
[MessageTray] handle "urgent" notifications specially

Urgent notifications jump to the front of the tray's notification
queue, and come up pre-expanded.


I don't think we'd ever talked about "jump to the front of the queue"
before, but it seems like it makes sense, and it simplifies the "urgent
notifications show up even when fullscreen" bug.

Review of attachment 159886 [details] [review]:

Looks good!

Review of attachment 159887 [details] [review]:

Looks good!

I was wondering if we could use source.notification.urgent when setting the source icon, so that we don't need to pass hints to the Source and parse them in two places, but it looks like it's too much trouble than it is worth at the moment because we first create the Source and only then create the Notification for it.

Attachment 159886 [details] pushed as 077f0c5 - [MessageTray] fix clutter warnings
Attachment 159887 [details] pushed as 263261c - [MessageTray] handle "urgent" notifications specially