After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611473 - [regression] outgoing buffers with a duration of zero
[regression] outgoing buffers with a duration of zero
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal blocker
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-01 13:08 UTC by Edward Hervey
Modified: 2010-03-01 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
asfdemux: Make sure we always set proper payload duration. (1.05 KB, patch)
2010-03-01 13:09 UTC, Edward Hervey 		committed Details | Review
asfdemux: Don't set durations of 0 on outgoing buffers. (1.22 KB, patch)
2010-03-01 13:09 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2010-03-01 13:08:07 UTC 
asfdemux pushes out buffers with a duration of zero on some broken streams. This is a regression, it should set the duration of those buffers to GST_CLOCK_TIME_NONE if it can't figure it out.
Comment 1 Edward Hervey 2010-03-01 13:09:01 UTC 
Created attachment 154943 [details] [review]
asfdemux: Make sure we always set proper payload duration.

Some (broken) streams will have a delta of 0, resulting in outgoing
buffers having durations of 0.
Comment 2 Edward Hervey 2010-03-01 13:09:08 UTC 
Created attachment 154944 [details] [review]
asfdemux: Don't set durations of 0 on outgoing buffers.

Some (broken) streams don't have the extended stream properties in
the header, resulting in applying a duration of zero on outgoing
buffers.
Comment 3 Tim-Philipp Müller 2010-03-01 13:27:07 UTC 
Comment on attachment 154944 [details] [review]
asfdemux: Don't set durations of 0 on outgoing buffers.

Looks good, please commit.
Comment 4 Edward Hervey 2010-03-01 15:51:48 UTC 
commit 48a1935cb0d809eb7666baecb7e954fd4e62c594
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Mon Mar 1 14:07:20 2010 +0100

    asfdemux: Don't set durations of 0 on outgoing buffers.
    
    Some (broken) streams don't have the extended stream properties in
    the header, resulting in applying a duration of zero on outgoing
    buffers.
    
    Fixes #611473

commit 79b154e4f787cdb513d258893c07efd935e30fa1
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Mon Mar 1 14:05:58 2010 +0100

    asfdemux: Make sure we always set proper payload duration.
    
    Some (broken) streams will have a delta of 0, resulting in outgoing
    buffers having durations of 0.
    
    Fixes #611473