After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611251 - Multiple connections for a single stream
Multiple connections for a single stream
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Internet Radio
1.5.3
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-27 02:02 UTC by Liran Nuna
Modified: 2011-08-18 23:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Ensure stream is closed after parsing playlist (1.02 KB, patch)
2011-07-26 17:35 UTC, Andy Street
committed Details | Review

Description Liran Nuna 2010-02-27 02:02:44 UTC
I listen to DI.FM Premium, where they restrict you to one stream at a time. 

When I play the stream with totem, the playpack goes fine for hours. Banshee, however, when encountering a network hiccup and/or playback pause, will try to open several streams to connect to the radio station, resulting in an automated email from DI.FM's servers saying I got multiple streams open.

Looking at banshee's stdio shows:

[Warn  17:45:17.927]  - DI.FM - Electro House (on DI.FM - Electro House) <00:00:00> [<unknown>] - The request timed out (in `System')
  at System.Net.HttpWebRequest.EndGetResponse (IAsyncResult asyncResult) [0x00000] 
  at System.Net.HttpWebRequest.GetResponse () [0x00000] 
  at Banshee.Playlists.Formats.PlaylistParser.Parse (Banshee.Base.SafeUri uri) [0x00000] 
  at Banshee.Streaming.RadioTrackInfo.LoadStreamUri (System.String uri) [0x00000]

The stream will then stop from playback until Banshee is restarted, or the station is re-added to the radio list.
Comment 1 Alexander Kojevnikov 2010-02-27 03:04:52 UTC
It's hard to localise the problem without having access to the station.

The station is connected to from two places:

 * GStreamer itself. I doubt it's the cause of the issue, considering the station works fine in Totem.

 * PlaylistParser [1]. The HTTP response created on line 95 should be properly closed. You can insert Console.WriteLine() calls into lines 118 and 147 to check if that's the case. Let me know if it's not closed, I will tell you how to debug it further.

[1] http://git.gnome.org/browse/banshee/tree/src/Core/Banshee.Services/Banshee.Playlists.Formats/PlaylistParser.cs
Comment 2 Liran Nuna 2010-03-07 21:51:57 UTC
This problem gone noticeably worse in the latest 1.5.4 (recently updated in Ubuntu ppa).

After less than 2 minutes of playback, the stream cuts off. 

The playback is fine in Totem (GStreamer backend).
Comment 3 Andy Street 2011-07-26 17:35:19 UTC
Created attachment 192688 [details] [review]
Ensure stream is closed after parsing playlist
Comment 4 Andy Street 2011-07-26 17:35:49 UTC
I'm able to reproduce this with HEAD. It appears that PlaylistParser does not always close the stream if the user links directly to a stream rather than a playlist.
Comment 5 Bertrand Lorentz 2011-08-18 23:18:32 UTC
Comment on attachment 192688 [details] [review]
Ensure stream is closed after parsing playlist

Thanks for the patch !
Committed !
Comment 6 Bertrand Lorentz 2011-08-18 23:18:42 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.