GNOME Bugzilla – Bug 610993
[gnome-shell.modules] Add gnome-shell-future target
Last modified: 2010-03-03 21:49:45 UTC
This basically drops gir-repository, but pulls in GTK+ and stack. TODO on this - we need to patch GTK+ to (possibly optionally) pull in stuff like pixbuf loaders and themes from the system as well.
Created attachment 154618 [details] [review] [gnome-shell.modules] Add gnome-shell-future target
Review of attachment 154618 [details] [review]: Slick. * gnome-shell-full not gnome-shell-future * Don't like having a duplicate gnome-shell module; it's going to hinder IRC communication if people actually have stuff in ~/gnome-shell/source/gnome-shell-future/. Can you use a metamodule instead? * jhbuildrc-custom-example should have '#modules = [ 'gnome-shell-full' ] added I'm not convinced that patching the GTK+ stack to have configure option is right - I'd rather investigate environment variables, and if that doesn't work, investigate extending/improving the GTK+ support for environment variables (e.g., support XDG_DATA_DIRS for finding themes)
Created attachment 154800 [details] [review] Add gnome-shell-future target This basically drops gir-repository, but pulls in GTK+ and stack. TODO on this - we need to patch GTK+ to (possibly optionally) pull in stuff like pixbuf loaders and themes from the system as well.
Review of attachment 154800 [details] [review]: Don't see a reason to random-abbrievate 'gnome-shell-gir-repository' to 'gnome-shell-girepo' - it will never be typed out in full by a user. To quote my previous review: > * jhbuildrc-custom-example should have '#modules = [ 'gnome-shell-full' ] added Other than that, looks OK to commit.