After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610789 - "search:" name instead of "x-nautilus-search"
"search:" name instead of "x-nautilus-search"
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Search Interface
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 684580 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-02-23 10:16 UTC by Arky
Modified: 2013-06-16 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Change 'x-nautilus-search:' to 'Search' on tooltips. (1.52 KB, patch)
2013-04-30 04:50 UTC, Ting-Wei Lan 		needs-work Details | Review
Use g_str_has_prefix() and EEL_SEARCH_URI (1.71 KB, patch)
2013-04-30 14:07 UTC, Ting-Wei Lan 		accepted-commit_now Details | Review

Description Arky 2010-02-23 10:16:04 UTC 
Provide a accessible name 'search:' instead of present (2.29.x) 'x-nautilus-search:'
Comment 1 Allan Day 2010-06-20 21:06:51 UTC 
Changing component as a part of ongoing bug reorganisation work.
Comment 2 André Klapper 2011-08-11 18:00:42 UTC 
This is in ../src/nautilus-window.c
But how can I test this?
Comment 3 William Jon McCann 2012-09-21 19:36:29 UTC 
*** Bug 684580 has been marked as a duplicate of this bug. ***
Comment 4 Ting-Wei Lan 2013-04-30 04:50:03 UTC 
Created attachment 242879 [details] [review]
Change 'x-nautilus-search:' to 'Search' on tooltips.
Comment 5 Cosimo Cecchi 2013-04-30 13:12:26 UTC 
Review of attachment 242879 [details] [review]:

The idea of the patch is fine, I have a little comment below.

::: src/nautilus-notebook.c
@@ +314,3 @@
 		location_name = g_file_get_parse_name (location);
+		title_name = nautilus_window_slot_get_title (slot);
+		if (strncmp (location_name, "x-nautilus-search://", 20) == 0) {

We have a define for the special search uri already (EEL_SEARCH_URI). You should also use g_str_has_prefix instead of strncmp().
Comment 6 Ting-Wei Lan 2013-04-30 14:07:18 UTC 
Created attachment 242915 [details] [review]
Use g_str_has_prefix() and EEL_SEARCH_URI

src/nautilus-window.c also use the string "x-nautilus-search". Maybe it should be modified?
Comment 7 Cosimo Cecchi 2013-04-30 15:04:09 UTC 
Review of attachment 242915 [details] [review]:

Looks good to me. The case in NautilusWindow is a little different and can be kept that way for now.