GNOME Bugzilla – Bug 610672
overlay examples are now inconsistent and broken
Last modified: 2010-02-22 13:21:45 UTC
patches comming
Created attachment 154374 [details] [review] add *all* files to ignore list I had this as a local commit already and would have pushed this after the repo is open again. the version tim committed misses the files generated by moc.
Created attachment 154375 [details] [review] fix find_video_sink and sync the examples I tried to make the examples similar in functionality. This patch catches up with tims additions to the gtk example (set the title and check for video sink). It also fixes the newly added find_video_sink in the gtk example.
Thanks for the fixes. -/* slightly convoluted way to find a working video sink that's not a bin */ +/* slightly convoluted way to find a working video sink that's not a bin, + * one could use autovideosink from gst-plugins-good instead + */ is no really true though, since autovideosink doesn't implement the GstXOverlay interface, so the code won't work with it in its current form.
Right. We could add more API to autovideosink. Right now one can filter sink candidates by caps. We could add a flags property and define a first flag as GST_AUTO_VIDEO_SINK_CAN_XOVERLAY = 1. Dunno if one would filter for e.g. videobalance etc.