GNOME Bugzilla – Bug 610648
Change Reconciled Split Dialog ignores pressing Cancel
Last modified: 2018-06-29 22:35:22 UTC
Created attachment 154354 [details] screenshot of the uneditable transaction Transaction descriptions are no longer editable after reconciliation of an account. In previous versions a warning dialog was shown although this is no longer showing up now. Platform/Version: Confirmed using WIN32 2.3.10 binaries installed via setup.exe on Windows 7. Steps to reproduce: 1. Create a new book, follow the wizards to create the default accounts. 2. Double click Assets=>Current Assets=>Checking Account 3. Create a transaction for today named "uneditable after reconcile" for $10.00 charged to an expense account. 4. Reconcile the checking account as of today with a -$10.00 balance 5. Select the "uneditable after reconcile" transaction and try to modify the description from the account register. Backspace causes the cursor to move but the text contents cannot be modified.
Can you choose the menu item Actions -> Reset Warnings and see whether the warning in question was disabled? You can enable it again there. On Linux (SVN trunk, r18713) this works fine. I can't test Windows right now, though. Can you check with one of the nightly builds? http://code.gnucash.org/builds/win32/trunk/ and you might have to uninstall the previous gnucash version before installing the new one.
Ok, Actions -> Reset Warnings "fixed" it. I then tried to bring the bug back but couldn't. I did some further testing and figured out the problem, it is a logic bug in the Change Reconciled Split dialog when a checkbox is checked but cancel is pressed. Here are updated directions for reproducing it: Also, this bug does affect the latest nightly build I could find at the URL provided above (r18708). Steps to reproduce: 1. Create a new book, follow the wizards to create the default accounts. 2. Double click Assets=>Current Assets=>Checking Account 3. Create a transaction for today named "uneditable after reconcile" for $10.00 charged to an expense account. 4. Reconcile the checking account as of today with a -$10.00 balance 5. Select the "uneditable after reconcile" transaction and try to modify the description from the account register. A "Change reconciled split?" dialog appears. 6. Check the "Remember and don't ask me again." button, then click *CANCEL*. 7. Reconciled transactions are now no longer editable and the dialog will never come back unless you do Actions->Reset Warnings and clear it.
Created attachment 221584 [details] [review] Reconcile patch This patch tests for the cancel response and if present by passes the setting of the gconf warning keys.
Comment on attachment 221584 [details] [review] Reconcile patch Thank you for your patch. I have committed in r22340 (trunk) and 22341 (2.4). I had to think this one through before committing... For me, there's no logic error as Phillip suggested. The dialog has two responses: either you choose to change the reconciled split or you choose not to change it (cancel). For me both answers could be remembered for future use cases. So in my view the whole experience was consistent. After thinking hard and reading the Gnome Human Interface Guidelines on Alerts [1], I could also imagine Cancel to mean "I changed my mind, I just want to go back to where I started just before the dialog popped up". In that case the only real action in the dialog is "Change the reconciled split". The two possible answers are no longer symmetrical. "Cancel" means to ignore the whole dialog in this case. The remember checkboxes hence only refer to the "Change split" choice. This is less obvious for me, but my sense of logic is that of a developer, not an ordinary user. So I accepted the change as written in the patch. I have added one more minor change in a subsequent commit: if you close the dialog using the close button in the title bar (the small cross), this should in my opinion be considered a "Cancel" action, while it was considered as a "No" answer. Before it didn't make a difference, but I'm pretty sure that you don't want to remember the "No" answer when you hit the close button. That could have lead to exactly the same situation as this bug tries to fix. Also of note is that this patch impacts several other places in GnuCash where the simple question dialog is used (I counted 15 in trunk). I lightly checked and it seems in most cases the new behavior works ok. Most of the dialogs use the same structure as the reconcile dialog: one action button and one cancel button. There were only one or two dialogs that had two action buttons and one cancel button. For these dialogs the new paradigm makes even more sense. [1] http://developer.gnome.org/hig-book/3.4/windows-alert.html.en
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=610648. Please update any external references or bookmarks.