After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610635 - Some GtkSourceCompletion{Proposal,Provider} functions had changed.
Some GtkSourceCompletion{Proposal,Provider} functions had changed.
Status: RESOLVED FIXED
Product: pygtksourceview
Classification: Bindings
Component: general
2.9.x
Other Linux
: Normal normal
: ---
Assigned To: pygtksourceview-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-21 21:46 UTC by Krzesimir Nowak
Modified: 2010-02-21 23:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch changing some const-gchar* into gchar* (2.41 KB, patch)
2010-02-21 22:26 UTC, Krzesimir Nowak 		none Details | Review

Description Krzesimir Nowak 2010-02-21 21:46:33 UTC 
With bug 610342 fixed an API change was introduced:
gtk_source_completion_proposal_get_label(), gtk_source_completion_proposal_get_markup(), gtk_source_completion_proposal_get_info(), gtk_source_completion_proposal_get_text() and gtk_source_provider_get_name() now return a new string, which needs to be freed with g_free().

Probably .defs file needs to be regenerated and/or mentioned functions overriden.
Comment 1 Paolo Borelli 2010-02-21 22:10:48 UTC 
should be a matter of changing

  (return-type "const-gchar*")

into

  (return-type "gchar*")



I am no pygtk expert, but I think regenerating the .defs is more trouble than editing by hand (I think it is generated the first time he lib was wrapped, but modified by hand later)
Comment 2 Krzesimir Nowak 2010-02-21 22:26:37 UTC 
Created attachment 154344 [details] [review]
Patch changing some const-gchar* into gchar*

Hand editing sounds resonable, so that is how I did it.
Comment 3 Paolo Borelli 2010-02-21 22:42:05 UTC 
looks good to me, though I have not tested it... let's push it, we'll find out soon enough if it is ok :)
Comment 4 Krzesimir Nowak 2010-02-21 23:33:07 UTC 
Pushed to master.