Bug 610613 – a vp6 flv file crashes totem and pitivi

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 610613 - a vp6 flv file crashes totem and pitivi


Summary:	a vp6 flv file crashes totem and pitivi


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-libav
Version:	git master
Hardware:	Other Linux

Importance:	High blocker
Target Milestone:	0.10.10
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Duplicates:	611946 (view as bug list)
Depends on:
Blocks:

Reported:	2010-02-21 15:52 UTC by Jean-François Fortin Tam
Modified:	2010-03-06 00:13 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
gstffmpegdec: Disable direct-rendering for svq1/vp56 decoders. (1.42 KB, patch) 2010-03-03 17:48 UTC, Edward Hervey	committed	Details \| Review

Description Jean-François Fortin Tam 2010-02-21 15:52:08 UTC

http://jeff.ecchi.ca/public/gstreamer-codec-autodetection/5%20-%20does%20not%20work/David%20Allen%20promo.flv

Cause totem and pitivi to crash if trying to play or import it. This is with gst ffmpeg 0.10.26.2.

Comment 1 Fabio Durán Verdugo 2010-02-21 21:29:28 UTC

Please repair the link 

Forbidden
You don't have permission to access /public/gstreamer-codec-autodetection/5 - does not work/David Allen promo.flv on this server.

Thank

Comment 2 Jean-François Fortin Tam 2010-02-21 22:09:21 UTC

Oops sorry, it's fixed now.

Comment 3 Fabio Durán Verdugo 2010-02-21 22:25:02 UTC

I can't reproduce, 
my version is 2.29.4 using GStreamer 0.10.26.1 in ubuntu lucid

Jean you can add the trace. Please see http://live.gnome.org/GettingTraces for more information on how to do so. Thanks in advance!

Comment 4 Sebastian Dröge (slomo) 2010-02-22 19:07:43 UTC

Crashes for me too with gst-ffmpeg from GIT:

Program received signal SIGSEGV, Segmentation fault.

+ Trace 220674

Thread 140736985966864 (LWP 7210)

#0 put_pixels16_sse2
at libavcodec/x86/dsputil_mmx.c line 446
#1 vp56_mc
at libavcodec/vp56.c line 365
#2 vp56_decode_mb
at libavcodec/vp56.c line 454
#3 vp56_decode_frame
at libavcodec/vp56.c line 605
#4 avcodec_decode_video2
at libavcodec/utils.c line 586
#5 avcodec_decode_video
at libavcodec/utils.c line 572
#6 gst_ffmpegdec_video_frame
at gstffmpegdec.c line 1686
#7 gst_ffmpegdec_frame
at gstffmpegdec.c line 2157
#8 gst_ffmpegdec_chain
at gstffmpegdec.c line 2571
#9 gst_pad_chain_data_unchecked
at gstpad.c line 4122
#10 gst_pad_push_data
at gstpad.c line 4351
#11 gst_single_queue_push_one
at gstmultiqueue.c line 919
#12 gst_multi_queue_loop
at gstmultiqueue.c line 1101
#13 gst_task_func
at gsttask.c line 238
#14 g_thread_pool_thread_proxy
at /tmp/buildd/glib2.0-2.23.4/glib/gthreadpool.c line 315
#15 g_thread_create_proxy
at /tmp/buildd/glib2.0-2.23.4/glib/gthread.c line 1893
#16 start_thread
at pthread_create.c line 300
#17 clone
at ../sysdeps/unix/sysv/linux/x86_64/clone.S line 112
#18 ??

Comment 5 Tim-Philipp Müller 2010-02-25 01:01:10 UTC

I believe this is a regression btw. I have seen this exact crash in FLV files as well recently that have always worked fine before.

Comment 6 Tim-Philipp Müller 2010-02-25 16:33:38 UTC

Marking as blocker for now.

Comment 7 Wim Taymans 2010-02-26 17:50:53 UTC

seems like an ffmpeg bug to me.

Comment 8 Tim-Philipp Müller 2010-02-26 18:02:42 UTC

Well ok, but do we really want to release a gst-ffmpeg that is known to crash with certain flv clips?

Guess we need to check if this has been fixed in ffmpeg yet..

Comment 9 Edward Hervey 2010-02-27 15:05:53 UTC

It now works fine with git of everything. Can someone else confirm ?

Comment 10 Tim-Philipp Müller 2010-03-02 20:55:49 UTC

> It now works fine with git of everything. Can someone else confirm ?

Still crashes for me with git. Did git clean -x -d -f; autogen.sh in gst-ffmpeg.

Comment 11 Edward Hervey 2010-03-03 13:00:06 UTC

Figured out why it wasn't failing for me. I was testing it on amd cpus, and the commit in ffmpeg revision 21736 made the backtrace in comment #4 not appear.

Comment 12 Edward Hervey 2010-03-03 14:15:02 UTC

This is actually due to an overwrite and not an alignment issue.

This needs to be fixed in one of two ways:

1) We revert to revision 21735 (February 10th)
2) We switch to revision 22095 which brings in a new method which gives uses the various strides to use. This would allow us, when using direct-rendering and filling the buffer ourself, to set the proper strides on our AVPicture.

Comment 13 Edward Hervey 2010-03-03 17:48:03 UTC

Created attachment 155155 [details] [review]
gstffmpegdec: Disable direct-rendering for svq1/vp56 decoders.

They use a non-standard stride which we can't support.

Fixes #610613

Comment 14 Tim-Philipp Müller 2010-03-03 18:02:49 UTC

> Created an attachment (id=155155) [details] [review]
> gstffmpegdec: Disable direct-rendering for svq1/vp56 decoders.
> 
> They use a non-standard stride which we can't support.
> 
> Fixes #610613

This works for me as well \o/

Comment 15 Edward Hervey 2010-03-03 18:03:58 UTC

commit d4e63b2727dbc030ba165fec1794de57a0fbf52e
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Wed Mar 3 18:46:25 2010 +0100

    gstffmpegdec: Disable direct-rendering for svq1/vp56 decoders.
    
    They use a non-standard stride which we can't support.
    
    Fixes #610613

Comment 16 Jean-François Fortin Tam 2010-03-06 00:13:49 UTC

*** Bug 611946 has been marked as a duplicate of this bug. ***