After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610447 - [flvdemux] Be more flexible in script tag (metadata) parsing
[flvdemux] Be more flexible in script tag (metadata) parsing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-19 12:46 UTC by Edward Hervey
Modified: 2010-03-11 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make script tag parsing more flexible (3.05 KB, patch)
2010-02-19 12:50 UTC, Edward Hervey 		none Details | Review

Description Edward Hervey 2010-02-19 12:46:48 UTC 
The following patch makes the Script Tag (metadata) parsing more flexible.

(1) Doesn't limit the number of parsed tag items to the nb_elements variable, it's just an indication according to specs (and validated through testing some files).
(2) Handle the list of Object type. It behaves the same way as the ECMA Array type, except that there isn't an indication of number of items.
Comment 1 Edward Hervey 2010-02-19 12:50:33 UTC 
Created attachment 154203 [details] [review]
Make script tag parsing more flexible
Comment 2 Edward Hervey 2010-03-11 16:06:08 UTC 
commit 95d087ed77bf4d123d6309aea360ecafa55e4e8f
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Fri Feb 19 13:39:04 2010 +0100

    flvparse: Make script tag parsing more flexible.
    
    * The nb_elements for arrays is just an indication, we can therefore ignore
      it and carry on parsing metadata items until we reach the end marker.
    * If type == 3, then the script tag contains a list of object followed
      by the end marker.
    
    Refactor code slightly to handle both cases
    
    https://bugzilla.gnome.org/show_bug.cgi?id=610447