After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610443 - baseaudiosink: clock can jump on setcaps
baseaudiosink: clock can jump on setcaps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-19 12:10 UTC by Thijs Vermeir
Modified: 2011-06-15 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
baseaudiosink: recalibrate clock on setcaps (1.60 KB, patch)
2010-02-19 12:10 UTC, Thijs Vermeir 		committed Details | Review

Description Thijs Vermeir 2010-02-19 12:10:37 UTC 
On the setcaps function of baseaudiosink the existing ringbuffer
is reconfigured. If the samples_per_seg are different this will cause
the clock to jump.
This bug can be triggered by live-switching analog/digital audio. Mike told on IRC
that he also experience this with playbin2 and files with different samplerate.
Comment 1 Thijs Vermeir 2010-02-19 12:10:40 UTC 
Created attachment 154199 [details] [review]
baseaudiosink: recalibrate clock on setcaps

Because the spec for the ringbuffer can change when changing
the caps, we must recalibrate the clock.
Comment 2 Wim Taymans 2010-02-22 11:44:57 UTC 
Seems like a good idea. I've having little trouble wrapping my head around all different possibilities (with and without clock slaving).

Commit after the freeze, I guess.
Comment 3 Sebastian Dröge (slomo) 2011-05-23 15:03:11 UTC 
commit dad50ad1fecfadfd0dd74dfe66259458cffeb9c2
Author: Thijs Vermeir <thijsvermeir@gmail.com>
Date:   Fri Feb 19 12:54:18 2010 +0100

    baseaudiosink: recalibrate clock on setcaps
    
    Because the spec for the ringbuffer can change when changing
    the caps, we must recalibrate the clock.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=610443