GNOME Bugzilla – Bug 610393
apply same style on hover for places and app
Last modified: 2010-05-05 15:44:15 UTC
Created attachment 154168 [details] [review] place style look like app style initial revision, tell me if you like it
Marking for design review. Presumably if this change was made, we'd want to do the same for Recent Items .. doesn't seem to make sense to have Places and Recent items different. Patch needs some obvious fixes (indentation, shouldn't move /* Places */ comment), but fine for testing.
ok the patch was only to know if it can't be the right way. not ready to be committed
Created attachment 154428 [details] [review] apply hovet style for place and recent
latest patch use and identical style for place and recent St.label in original function don't use style option so i use an st.button instead of a label ( changed alignment too ) like already done in placeDisplay.js
(In reply to comment #4) > St.label in original function don't use style option so i use an st.button > instead of a label ( changed alignment too ) like already done in > placeDisplay.js St.Label does support styling, it just doesn't know about pseudo classes (:hover). Porting docDisplay to St.Button is not necessarily a bad idea, but you should be aware that right now it breaks drag-n-drop (see bug 609218), so I suggest postponing this transition until that is fixed.
Created attachment 154458 [details] [review] Another one but button are not expanded and with more left right padding
Created attachment 154529 [details] [review] Another one but button are not expanded and with more left right padding this patch enable the 'button-release-event' on St.Button
Created attachment 154542 [details] Strange space before name on stbutton label if i use St.Button instead of St.Label only in the file you can see on image are show some space before label, it's strange because there's no space on filename and it's happen only for this file.
Comment on attachment 154428 [details] [review] apply hovet style for place and recent >- let name = new St.Label({ style_class: 'dash-recent-docs-item', >- text: docInfo.name }); >+ let name = new St.Button({ style_class: 'dash-recent-docs-item', >+ label: docInfo.name, >+ x_align: St.Align.START }); With latest git, you should be able to use an St.Label still. Just set the "reactive" and "track_hover" properties to true, and it will use the hover pseudo-class as needed. Hopefully that should fix the problem in your screenshot too.
Created attachment 157200 [details] [review] new patch for latest git i made this new patch
Created attachment 157209 [details] [review] another patch with bit different theme
Review of attachment 157209 [details] [review]: This one conflicts with Florian's changes in https://bugzilla.gnome.org/show_bug.cgi?id=610385 Let's resolve it after that lands. Marking needs-work until then.
Created attachment 157393 [details] [review] conflict resolved new patch after last commit
Created attachment 157607 [details] [review] conflict resolved with git 750672061aabd5d443614770d39ab698508ccb65
This looks good, and I think we can go ahead and apply it (http://live.gnome.org/GnomeShell/Design/Whiteboards/FindingAndReminding has some big changes in this area, but this is an improvement for now.) To apply it, we need it attached as a git commit rather than a raw diff. See: http://live.gnome.org/GnomeShell/Development/WorkingWithPatches For more information about how to do this.
Comment on attachment 157607 [details] [review] conflict resolved with git 750672061aabd5d443614770d39ab698508ccb65 Marking needs-work pending reformatting.
Created attachment 160241 [details] [review] Add same style for app, place , recent
sorry my email was wrong on attach.
Review of attachment 157607 [details] [review]: reviwed and committed new one https://bugzilla.gnome.org/attachment.cgi?id=160241
sorry for mistake, i wanted to mark attach 157607 as reviewed. the correct one is attach 160241
Review of attachment 160241 [details] [review]: Please read the email about commit message style at: http://lists.cairographics.org/archives/cairo/2008-September/015092.html (Linked to from http://live.gnome.org/GnomeShell/Development/WorkingWithPatches) You can edit your commit message with 'git commit --amend' before reattaching a new patch.
Created attachment 160298 [details] [review] Add same style for app, place , recent https://bugzilla.gnome.org/show_bug.cgi?id=610393 Author: Discardi Nicola <discardi.nicola@gmail.com> modified: data/theme/gnome-shell.css gnome-shell.css was modified to apply same style for application,place and recent. I start this work because i don't like default theme and wasn't a way to understand when place or item in recent was selected or not. On branch master Your branch is ahead of 'origin/master' by 1 commit.
ok i use git format git bz i insert what and why. i forget something?
Created attachment 160352 [details] [review] [dash] Make the style for places and recent items similar to apps
Attachment 160352 [details] pushed as 39a24b9 - [dash] Make the style for places and recent items similar to apps