After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610089 - Flash players are unable to show x264 encoded streams
Flash players are unable to show x264 encoded streams
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal critical
: 0.10.14
Assigned To: Tim-Philipp Müller
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-16 12:28 UTC by Vittorio Palmisano
Modified: 2010-04-13 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (871 bytes, patch)
2010-02-16 12:28 UTC, Vittorio Palmisano 		committed Details | Review

Description Vittorio Palmisano 2010-02-16 12:28:13 UTC 
Created attachment 153913 [details] [review]
Patch

Flash players are unable to show x264 encoded stream.
I've found that gst_x264_enc_header_buf wrote a bad sps value into h264 encoded header.
In attachment, the patch that correct this error.
Comment 1 Tim-Philipp Müller 2010-02-16 12:40:36 UTC 
Thanks for the patch. Marking as blocker for the release.
Comment 2 Tim-Philipp Müller 2010-02-16 14:15:07 UTC 
commit 09d493f21d540a66c23913e75e5a338e04dde219
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue Feb 16 14:08:12 2010 +0000

    x264enc: add caps check to x264enc unit test
    
    Add some minimal caps checking to x264enc unit test.
    
    See #610089.

commit 35dd89951d8bb1c094da65480e4197efdfb4e93c
Author: Vittorio Palmisano <vpalmisano@gmail.com>
Date:   Tue Feb 16 13:25:11 2010 +0000

    x264enc: fix up avcC header construction and playback by flash players
    
    Fix off-by-one bug when constructing the avcC header chunk: we
    wrote wrong profile info into the header. The first byte in the
    SPS NAL we get from x264 is the nal type, not the profile_idc.
    
    Also add some debug logging.
    
    Fixes #610089.
Comment 3 Mark Nauwelaerts 2010-04-13 14:57:48 UTC 
While this commit fixes an off-by-one for a newer libx264, it introduced an off-by-one for older ones.

Following commit should take care for both:

commit 61643c7d8994c0bf6be30c3c2a1e3cff8d8a0f6a
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Tue Apr 13 16:31:25 2010 +0200

    x264enc: fix up avcC header construction

    Fix off-by-one introduced by commit 35dd89951d8bb1c094da65480e4197efdfb4e93c
    for BUILD_X264 < 76.

    Also fixes #610089.