After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610003 - calls gdk_threads_enter/leave without gdk_threads_init
calls gdk_threads_enter/leave without gdk_threads_init
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Appearance
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-15 15:41 UTC by Matthias Clasen
Modified: 2010-03-10 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (625 bytes, patch)
2010-02-15 16:43 UTC, Matthias Clasen 		none Details | Review
a working patch (1.03 KB, patch)
2010-02-15 17:38 UTC, Matthias Clasen 		reviewed Details | Review
Calls gdk_threads_enter/leave without gdk_threads_init (1.66 KB, patch)
2010-03-10 12:19 UTC, Bastien Nocera 		committed Details | Review

Description Matthias Clasen 2010-02-15 15:41:36 UTC 
The appearance capplet uses some gtk calls from threads, trying to protect them by gdk_threads_enter/leave. But it never calls gdk_threads_init, so those enter/leave calls don't do any good, and in fact, people are reporting crashes that look like they might be caused by this.
Comment 1 Matthias Clasen 2010-02-15 16:43:12 UTC 
Created attachment 153841 [details] [review]
patch
Comment 2 Matthias Clasen 2010-02-15 17:06:50 UTC 
Grr, of course, adding that shows the locking to be deficient. Ie, it locks up in various places now.
Comment 3 Matthias Clasen 2010-02-15 17:38:04 UTC 
Created attachment 153847 [details] [review]
a working patch

This patch appears to be working better.
Comment 4 Jens Granseuer 2010-02-20 09:52:35 UTC 
Comment on attachment 153847 [details] [review]
a working patch

Apart from the legendary tabs vs. spaces issues, please commit.
Comment 5 Bastien Nocera 2010-03-10 12:19:37 UTC 
Created attachment 155734 [details] [review]
Calls gdk_threads_enter/leave without gdk_threads_init

Fix GTK+ multi-threading.
Comment 6 Bastien Nocera 2010-03-10 12:25:45 UTC 
Attachment 155734 [details] pushed as e34e6b4 - Calls gdk_threads_enter/leave without gdk_threads_init