After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609639 - xviddec plugin caps does not allow MPEG 4 video - trivial fix
xviddec plugin caps does not allow MPEG 4 video - trivial fix
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal minor
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-11 12:08 UTC by Nick
Modified: 2011-05-23 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Nick 2010-02-11 12:08:18 UTC
The XVid Plugins use their own caps "video/x-xvid", however as XVid is an implementation of MPEG4 it would be useful for the caps to allow for MPEG4 as well. The Encoder does currently allow the src caps to be MPEG4, however the Decoder sink caps only allows xvid. As MPEG4 decoders are defined by the specification I believe that simply changing the caps to allow MPEG4 should work. This would be useful as the XVID decoders are very efficient and could be used instead of ffdec_mpeg4.

The fix is absolutely trivial, I've tested it by adding the following caps to the decoder's sink template in "/gstpluginsbad/ext/xvid/xviddec.c":

  "video/mpeg, "
  "mpegversion = (int) 4, "
  "systemstream = (boolean) FALSE, "
  "width = (int) [ 0, MAX ], "
  "height = (int) [ 0, MAX ], " "framerate = (fraction) [ 0/1, MAX ]

This then works with the following pipelines:
  gst-launch videotestsrc ! ffenc_mpeg4 ! xviddec ! ffmpegcolorspace ! xvimagesink

  gst-launch videotestsrc ! xvidenc ! 'video/mpeg, mpegversion=(int)4' ! xviddec ! ffmpegcolorspace ! xvimagesink

Nick
Comment 1 Sebastian Dröge (slomo) 2011-05-23 15:31:17 UTC
commit 4e01ce3fd267729d2ddc264ddf87bfd8b51e2d05
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Mon May 23 17:29:56 2011 +0200

    xviddec: Add video/mpeg,mpegversion=4 to the caps
    
    Fixes bug #609639.