After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609591 - code writer ignores the instance_pos attribute
code writer ignores the instance_pos attribute
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Delegates
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-10 22:32 UTC by Víctor Manuel Jáquez Leal
Modified: 2010-02-12 19:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Put the instance_post attribute on delegates in the code writer (848 bytes, patch)
2010-02-10 22:32 UTC, Víctor Manuel Jáquez Leal 		none Details | Review

Description Víctor Manuel Jáquez Leal 2010-02-10 22:32:54 UTC 
Created attachment 153484 [details] [review]
Put the instance_post attribute on delegates in the code writer

When having a custom vapi file specifying delegates with the instance_pos attribute, the code writer ignores this attribute.

Example:

grilo-0.1-custom.vala contains:

[CCode (instance_pos = 2.1)]
public delegate void MediaSourceMetadataCb (Grl.MediaSource source, Grl.ContentMedia? media, GLib.Error error);

And the output grilo-0.1.vapi contains:

[CCode (cheader_filename = "grilo.h")]
public delegate void MediaSourceMetadataCb (Grl.MediaSource source, Grl.ContentMedia? media, GLib.Error error);

I'm adding a proposal patch.
Comment 1 Víctor Manuel Jáquez Leal 2010-02-12 19:57:24 UTC 
fixed on master:

commit e8338e02d8c2366cd2b71aff8bae0daec92af0e9
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Wed Feb 10 23:22:05 2010 +0100

    Put the instance_pos attribute in delegates in code writer
    
    Fixes bug 609591.