GNOME Bugzilla – Bug 609576
Pre-light buttons in the top panel
Last modified: 2011-03-16 18:53:10 UTC
We should pre-light Activities, clock, and user menu buttons on mouse over to indicate to the user that they are clickable.
I'm not sure whether this should be done. The top panel behaves a lot like a menu bar: all items are clickable. Menu bars in GTK+ do not pre-light, so for consistency these items probably should not either.
is this still desired? if we want it, it's basically just a matter of adding ".panel-button:hover" to the .panel-button:active, etc line (unless we want the prelight to be different from the highlight-when-pressed)
Created attachment 160580 [details] [review] Pre-light Activities button on mouse over Perhaps as a compromise the Activities button could be pre-lit while leaving the clock and user menu as they are. The activity button is the most used and it might be nice to get some visual feedback on mouse over.
Review of attachment 160580 [details] [review]: This needs ui-review. One of the design goals of gnome-shell is a consistent behaviour of panel items ("menu-like"), so I'm not sure if it's a good idea to limit the prelighting to the activities button (though it's obviously special ...) Style comments below. ::: data/theme/gnome-shell.css @@ +1,1 @@ +a/* Copyright 2009, Red Hat, Inc. Oooops! @@ +141,3 @@ + background-gradient-start: #3c3c3c; + background-gradient-direction: vertical; +#panelActivities:hover { Instead of repeating the same style used for .panel-button:active, add the selector there - this way, if we decide to change the button style, it can be done in one place.
Created attachment 160584 [details] [review] Pre-light buttons in the top panel on mouseover This patch pre-lights all the panel buttons using the method suggested in Dan Winship's post. Lighting all the buttons this way seems more consistent.
(In reply to comment #4) > This needs ui-review. One of the design goals of gnome-shell is a consistent > behaviour of panel items ("menu-like"), so I'm not sure if it's a good idea to > limit the prelighting to the activities button (though it's obviously special Thank you, Florian. After using it this way for a while I agree. If you decide to pre-light the panel buttons then it would be best to have them behave consistently using Dan's method.
Review of attachment 160584 [details] [review]: If we want this, it is OK to commit - Jon? It might also be worth trying a different prelight effect, like the one used in the dash ...
(In reply to comment #7) > If we want this, it is OK to commit - Jon? Yes that's fine with me, thank you for the feedback on this. > It might also be worth trying a different prelight effect, like the one used in > the dash ... I tested this out using the same effect the dash uses and it doesn't look as good as the current panel active effect you currently have. Maybe the effect could be tweaked later down the line.
(In reply to comment #8) > (In reply to comment #7) > > If we want this, it is OK to commit - Jon? > > Yes that's fine with me, thank you for the feedback on this. Oh, I did not misspell John - Jon Mccann is one of the Gnome shell designers; we should get his input before pushing this forward :)
Oops, sorry, I thought it was a bit odd asking me to commit it :-)
*** Bug 597782 has been marked as a duplicate of this bug. ***
Consulted with Jakub and we'd like prelight to: :hover { color: #fff }
Created attachment 183312 [details] [review] Prelight panel items on hover In order to give feedback when the user hovers over items on the panel, we should prelight them.
Created attachment 183399 [details] [review] Prelight-panel-items-on-hover Rebase from master
Looks good. I'd like to get this in.
Review of attachment 183399 [details] [review]: Looks good.
Created attachment 183474 [details] [review] Prelight-panel-items-on-hover Fixed author name and contact info. Per irc conversation. Should be good to go now.