After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609521 - [main.js] Fix up "window-added/removed" callbacks
[main.js] Fix up "window-added/removed" callbacks
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-10 10:45 UTC by drago01
Modified: 2010-02-10 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[main.js] Fix up "window-added/removed" callbacks (1.40 KB, patch)
2010-02-10 10:45 UTC, drago01 		committed Details | Review

Description drago01 2010-02-10 10:45:26 UTC 
Currently the window-added and window-removed callbacks in
main.js:_onWorkspaceSwitched access the first parameter as metaWindow object,
but in fact the first one passed is the workspace (metaWorkspace).

Fix it by using the second parameter instead (which is a metaWindow object).
Comment 1 drago01 2010-02-10 10:45:57 UTC 
Created attachment 153402 [details] [review]
[main.js] Fix up "window-added/removed" callbacks
Comment 2 Owen Taylor 2010-02-10 14:20:08 UTC 
Review of attachment 153402 [details] [review]:

Good catch, looks good to commit
Comment 3 drago01 2010-02-10 14:35:47 UTC 
Comment on attachment 153402 [details] [review]
[main.js] Fix up "window-added/removed" callbacks

Commited as 3a7dc32