After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609406 - The window of viewer mode doesn't honor the default window size in f-spot.glade
The window of viewer mode doesn't honor the default window size in f-spot.glade
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Browsing
0.6.x
Other Linux
: Normal normal
: 0.7.1
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-09 11:35 UTC by Gary Ching-Pang Lin
Modified: 2010-06-30 08:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add default height and width (375 bytes, patch)
2010-02-10 04:32 UTC, Gary Ching-Pang Lin 		none Details | Review
Skip window.SetDefaultSize() if width/height is not set yet (679 bytes, patch)
2010-02-10 06:43 UTC, Gary Ching-Pang Lin 		none Details | Review
Use F-Spot's default size as the default for view mode too (1.18 KB, patch)
2010-06-26 22:39 UTC, Iain Lane 		committed Details | Review

Description Gary Ching-Pang Lin 2010-02-09 11:35:20 UTC 
OS: openSUSE 11.2

When I open a picture in the viewer mode for the first time launch, the size of the viewer window is quite small, says 320x206. However, in f-spot.glade, the default size of the viewer window is set to 640x480, but the viewer window doesn't follow it.
Comment 1 Gary Ching-Pang Lin 2010-02-10 04:32:40 UTC 
Created attachment 153382 [details] [review]
Patch to add default height and width

I made a patch to set the default values for the height and width of the viewer and it works for me.
Comment 2 Gary Ching-Pang Lin 2010-02-10 06:43:07 UTC 
Created attachment 153388 [details] [review]
Skip window.SetDefaultSize() if width/height is not set yet

The patch checks the return value of Preferences.Get() and skips
window.SetDefaultSize() if there is no existed width or height, so f-spot
viewer will follow f-spot.glade and no more hardcoded value is needed :)
Comment 3 Iain Lane 2010-06-26 22:39:13 UTC 
Created attachment 164710 [details] [review]
Use F-Spot's default size as the default for view mode too

If the view mode height and width are unset, fall back to using the
default height and width (from the glade file).

Original patch from Gary Ching-Pang Lin.
Comment 4 Iain Lane 2010-06-26 22:43:39 UTC 
Comment on attachment 153388 [details] [review]
Skip window.SetDefaultSize() if width/height is not set yet

This didn't apply any more; I fixed it to do so and made a proper git formatted patch at the same time. Thanks for your contribution!
Comment 5 Ruben Vermeersch 2010-06-30 08:19:29 UTC 
Attachment 164710 [details] pushed as 69efa72 - Use F-Spot's default size as the default for view mode too


Thanks, merged!