GNOME Bugzilla – Bug 609063
[vorbisdec] also support integer vorbis decoder (tremor) library implementation
Last modified: 2010-02-15 11:25:19 UTC
The ivorbisdec element in -bad is basically a copy-and-minor-adjust from -base vorbisdec, or at least some version of it, as it is not always so maintained. So, rather than having a not-so-well maintained copy, some patches follow that slightly refactor vorbisdec to allow the resulting code to also serve as ivorbisdec element (and the latter could then be removed from -bad).
Created attachment 153071 [details] [review] Patch 1: some minor changes as preparation
Created attachment 153073 [details] [review] Patch 2: refactor to support variant API and other caps
Sounds like a very good idea and the patch looks good to, please push after freeze :)
Mark, please commit this now and remove the ivorbis plugin from gst-plugins-bad. IIRC Tim wanted to keep core/base frozen mainly for this plugin move.
Indeed.
Should only the ivorbisdec element in -bad be removed, or the whole ivorbis plugin (which also still contains the --fairly obsolete-- vorbisfile element) ?
I think we should just remove the vorbisfile element.
(In reply to comment #7) > I think we should just remove the vorbisfile element. Agreed. And vorbisdec should get PRIMARY rank, ivorbisdec SECONDARY
In -bad: commit e3081a71ba96cf2a9d1eab79836a39e59177af9a Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Mon Feb 15 11:55:07 2010 +0100 Moved 'ivorbis(dec)' from -bad to -base. Fixes #609063. ---- In -base: commit 8e5e2dbe49c7895a072f462befa5fc4781cc1301 Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Mon Feb 15 12:10:10 2010 +0100 ivorbisdec: set rank to SECONDARY commit 32dff24552b09ed9e14303c071cc0546d154dd69 Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Mon Feb 15 12:09:53 2010 +0100 vorbisdec: also support ivorbis tremor decoder ... which only needs a bit of refactoring and extracting to support the minor difference in (i)vorbis interface. Fixes #609063. commit 5e06eaa5170c8cd90fabea6db9bf658d2fc6facd Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Wed Feb 3 14:37:43 2010 +0100 vorbisdec: reduce some hard-coding ... such as assuming float all over, and base src caps on template caps.