After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608643 - libpng 1.4.x incompatibilities
libpng 1.4.x incompatibilities
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-gl
0.10.1
Other Windows
: Normal normal
: 0.10.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-01 01:36 UTC by David Hoyt
Modified: 2010-03-23 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstgl patch (1.65 KB, patch)
2010-02-01 01:36 UTC, David Hoyt 		none Details | Review

Description David Hoyt 2010-02-01 01:36:54 UTC 
Created attachment 152703 [details] [review]
gstgl patch

libpng 1.4.0+ has removed some typedefs. I've attached a quick fix, but everywhere png_infopp_NULL and int_p_NULL appear should be substituted with NULL. But this patch does allow for backward compatibility.
Comment 1 Julien Isorce 2010-03-09 00:26:45 UTC 
commit eb3170e516b89e496f84bbd561d9d5aa468861ff
Author: David Hoyt <dhoyt@llnl.gov>
Date:   Tue Mar 9 01:24:06 2010 +0100

    glbumper/gldifferencematte/gloverlay: libpng 1.4.x compatible

    Fix bug #608643
Comment 2 LRN 2010-03-23 12:15:47 UTC 
I would argue against such fix in favor of using typecasts directly (such as "(png_infopp) NULL") instead of creating needless macros.

libpng changelog from 1.0.x to 1.2.x says:

Typecasted NULL definitions such as
   #define png_voidp_NULL            (png_voidp)NULL
were eliminated.  If you used these in your application, just use
NULL instead.

That is, png_*_NULL macros are only useful for maintaining compatibility with pre-1.2.x versions of libpng, as these macros were dropped right in 1.2.0 (which came out roughly 9 years ago, in 2001).