GNOME Bugzilla – Bug 608583
Power manger tooltips are over complex and unclear
Last modified: 2010-08-28 22:37:33 UTC
Running Ubuntu 9.10 on netbook I've noticed the battery messages are very over complicated considering the simple info they need to convey one or two words would be enough in most cases. Examples 1) On your home page: http://projects.gnome.org/gnome-power-manager/ "You have approximately 3 minutes of remaining battery life (2%). Plug in your AC adaptor to avoid loosing data" 19 words. It is obvious that a charger is needed. It does not need to be mentioned.. Why so long to make such a basic point? "Only 3 minutes of battery remaining!" Proposed change: a) "You have approximately", "life" is not necessary. b) I charge my netbook from a charger pack, it's not an AC adaptor. c) Default netbook config is to hibernate or suspend.. so there may be no data lost. d) "data" is a programmers word. General users will understand "your work". 2) "discharging" word. It's a technical programmers word Click on the battery icon and it shows "Laptop battery (83.4%)". Hover over the battery icon and it shows different text "Laptop battery discharging (83.4%) Proposed change: a) ditch "discharging" b) drop 1 decimal place, so it is 83% 3) Tooltip text is different from text when click. The icon indicates charging/discharging status, so no need to indicate that on tooltip. 4) the Black text box which appears when unplugging charger/battery pack also is overcomplicated. It only needs to say "Running on battery power"
Patches welcome.
Created attachment 152861 [details] [review] Message simplications
Hello Attached patch for gpm-notify.c and gpm-devicekit.c and gpm-manager.c. Please review and let me know if you apply it. All are the message simplifications I opened this bug ticket with, except PDA typo in gpm-manager.c "computeis" Best regards, Jon p.s. this is my first gnome patch!
Hello. Has anyone had chance to take a look at the patch? I'm eager for feedback! Cheers, Jon
Yes, sorry. It's been on my TODO for ages now. In principle I like your patch; however I think you've gone a little too far. The message text in particular still have to be a sentence, and right now it seems a bit like a coded message. For instance, "Shutdown in %s if power not connected." sounds like a robot is saying it :-) Maybe a better example might be: -message = g_strdup_printf (_("Your cell phone is very low in power (%.1f%%). " - "This device will soon stop functioning if not charged."), +message = g_strdup_printf (_("Cell phone power very low (%.1f%%). " + "Cell phone will stop working if not charged."), This probably needs to be "Cell phone power is very low (%.0f%%)" Do you see what i mean? Thanks.
Hi Richard Thanks for reviewing the patch. I quite like robot sounding messages! ;) However, I do see your point. I think inserting the odd "is" again would make them sentences again. Shall I submit a revised patch? or would you like to make the changes you are happy with? Cheers, Jon
(In reply to comment #6) > Shall I submit a revised patch? Please. Thanks.
Created attachment 156074 [details] [review] Revised patch with simplified notifications, still including "is" Revised patch with simplified notifications, still including "is"
Hi Richard Please find attached revised patch for review/commit. Let me know what you think! Cheers, Jon
Ping! Just quick reminder to review the patch when have a moment. Cheers, Jon
Hi Richard Do you have any update on this? I'd lke to get this patch in soon, as ticket has been open for a while and I spent so much time preparing it. Best regards, Jon
I've committed the following patches: commit 6fd4b93cdb5cdaee1d78cea0e7c66358569bd441 Author: Richard Hughes <richard@hughsie.com> Date: Mon May 10 14:38:23 2010 +0100 Remove some 'The' prefixes to notification messages :100644 100644 88e20de... 50ac2cf... M src/gpm-manager.c commit 54a967e36a2c5f3c8aef99ca87f48166cd859718 Author: Richard Hughes <richard@hughsie.com> Date: Mon May 10 14:35:09 2010 +0100 Remove 'attached to this computer' from warning messages as it's redundant :100644 100644 8196c52... 88e20de... M src/gpm-manager.c commit f17ba8edd7c3aee744d85d8c069d37d8dbcf5d8e Author: Richard Hughes <richard@hughsie.com> Date: Mon May 10 14:33:07 2010 +0100 Remove 'Your' prefix to notification messages :100644 100644 6a72be1... 8196c52... M src/gpm-manager.c commit 3eab84ac45bba73aee5c93708376580abc28b2c9 Author: Richard Hughes <richard@hughsie.com> Date: Mon May 10 14:30:43 2010 +0100 Remove 'You have' prefix to notification messages :100644 100644 58556c7... 6a72be1... M src/gpm-manager.c commit 4ba54c0e01924a3ed8bc02eee69ff67c8ad2210a Author: Richard Hughes <richard@hughsie.com> Date: Mon May 10 14:25:26 2010 +0100 Remove the decimal place precision from the warning notification percentages :100644 100644 a9b7ef9... 58556c7... M src/gpm-manager.c Some of the message strings you've suggested in your patch don't make sense as shorter strings ("Will now hibernate.") -- but if you resync your patch with git master I would be happy to review any more strings.
Hi Richard Thank you for incorporating changes. I've not got time currently to look again, so you could close the ticket if you prefer. In next Ubuntu release I will look again at the power manager. Thank you again for making the changes. Jon
can we close this bug?
Resolved by Richard's patch. Fixed.