After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608345 - Wrong reference on gdk_keymap_translate_keyboard_state
Wrong reference on gdk_keymap_translate_keyboard_state
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other All
: Normal trivial
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-01-28 15:04 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2010-02-09 11:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed solution (1.51 KB, patch)
2010-01-28 15:04 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00) 		none Details | Review
Updated patch (1.76 KB, patch)
2010-01-29 14:08 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00) 		accepted-commit_now Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2010-01-28 15:04:20 UTC 
Created attachment 152490 [details] [review]
Proposed solution

The documentation of this function has this sentence:

"See gdk_keyval_get_keys() for a explanation of groups and levels"

But gdk_keyval_get_keys doesn't exists.

You can find the explanation of groups and levels at the description section on http://library.gnome.org/devel/gdk/unstable/gdk-Keyboard-Handling.html

A proposed patch, with a provisional solution is attached.
Comment 1 Matthias Clasen 2010-01-28 18:19:03 UTC 
We should make that a link, probably by using <link> or <xref>
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2010-01-29 14:08:32 UTC 
Created attachment 152574 [details] [review]
Updated patch

Updated patch after Mathias Clasen comment.

The final output in the doc file is:

"See the section called “Description” for an explanation of groups and levels".
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2010-01-29 14:11:57 UTC 
(In reply to comment #2)
> Created an attachment (id=152574) [details] [review]
> Updated patch
> 
> Updated patch after Mathias Clasen comment.

Sorry, I mean Matthias Clasen comment.
Comment 4 Matthias Clasen 2010-02-09 04:15:22 UTC 
Comment on attachment 152574 [details] [review]
Updated patch

Looks good.
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2010-02-09 11:25:26 UTC 
(In reply to comment #4)
> (From update of attachment 152574 [details] [review])
> Looks good.

Ok, so applying the patch and closing the bug.

Thanks.