After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608264 - UI blocks during execution of git commands
UI blocks during execution of git commands
Status: RESOLVED FIXED
Product: giggle
Classification: Other
Component: libgiggle
0.4.x
Other All
: Normal normal
: ---
Assigned To: giggle-maint
Depends on:
Blocks:
 
 
Reported: 2010-01-27 16:15 UTC by Florian Müllner
Modified: 2010-03-22 01:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Improve responsiveness when executing git commands (1.63 KB, patch)
2010-01-27 16:15 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2010-01-27 16:15:29 UTC 
Due to the way command output is read in GiggleDispatcher, the
program may block waiting for I/O if a command does not write to
stdout after some initial output.

Note that while this is somehow related to bug 566329, comment 3, it
is IMHO a separate issue.
Comment 1 Florian Müllner 2010-01-27 16:15:34 UTC 
Created attachment 152419 [details] [review]
Improve responsiveness when executing git commands

Set G_IO_FLAG_NONBLOCK on the command's pipe to avoid I/O blocking.
Comment 2 Javier Jardón (IRC: jjardon) 2010-02-02 17:32:19 UTC 
Comment on attachment 152419 [details] [review]
Improve responsiveness when executing git commands

patch looks good, waiting for Mathias final review
Comment 3 Javier Jardón (IRC: jjardon) 2010-03-22 00:31:14 UTC 
Comment on attachment 152419 [details] [review]
Improve responsiveness when executing git commands

Please, go ahead and commit this
Comment 4 Florian Müllner 2010-03-22 01:01:07 UTC 
Attachment 152419 [details] pushed as fbc6b19 - Improve responsiveness when executing git commands