After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608255 - [speex] speexenc crash and leaks in rtpspeexpay and speexdec
[speex] speexenc crash and leaks in rtpspeexpay and speexdec
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-27 14:34 UTC by Mark Nauwelaerts
Modified: 2010-01-27 17:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check a bit more for proper setup state (832 bytes, patch)
2010-01-27 14:34 UTC, Mark Nauwelaerts 		committed Details | Review
Fix occasional buffer leak in rtpspeexpay (1.02 KB, patch)
2010-01-27 14:35 UTC, Mark Nauwelaerts 		committed Details | Review
Reset and free some more decoder related structures (838 bytes, patch)
2010-01-27 14:35 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2010-01-27 14:34:20 UTC 
Created attachment 152401 [details] [review]
Check a bit more for proper setup state

As subject indicates, speexenc might perform some undesirable arithmetic in e.g. a non-negotiated pipeline.
Comment 1 Mark Nauwelaerts 2010-01-27 14:35:11 UTC 
Created attachment 152402 [details] [review]
Fix occasional buffer leak in rtpspeexpay
Comment 2 Mark Nauwelaerts 2010-01-27 14:35:52 UTC 
Created attachment 152403 [details] [review]
Reset and free some more decoder related structures
Comment 3 Mark Nauwelaerts 2010-01-27 17:29:08 UTC 
commit 77509c80c99b5f614473d09ef68bfa3ce2a08f62
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Jan 27 15:24:52 2010 +0100

    speexdec: free some more when resetting

    Fixes #608255.

commit 71e35b2bf341b9073340b5ca776cbd45605b7965
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Jan 27 15:24:24 2010 +0100

    rtpspeexpay: fix occasional buffer leak

    Fixes #608255.

commit c529145e4b1b74fcfdf8c9a387a7dafdcd4eb4b5
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Jan 27 15:22:46 2010 +0100

    speexenc: prevent invalid arithmetic if not setup yet

    Fixes #608255.