After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608244 - Use GtkSpinner
Use GtkSpinner
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks: 613178
 
 
Reported: 2010-01-27 12:13 UTC by Jonh Wendell
Modified: 2010-06-05 14:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace custom VinagreSpinner by a GtkSpinner (29.71 KB, patch)
2010-03-22 14:57 UTC, Stéphane Maniaci 		none Details | Review
Replace custom VinagreSpinner by a GtkSpinner (29.65 KB, patch)
2010-03-22 15:18 UTC, Stéphane Maniaci 		none Details | Review
Replace custom VinagreSpinner by a GtkSpinner (30.03 KB, patch)
2010-04-08 08:15 UTC, Stéphane Maniaci 		committed Details | Review

Description Jonh Wendell 2010-01-27 12:13:11 UTC 
Instead of our own copy of gedit-spinner.

This requires gtk+ 2.20, so, let's wait for vinagre 2.30 to be released.
Comment 1 Stéphane Maniaci 2010-03-22 14:57:05 UTC 
Created attachment 156752 [details] [review]
Replace custom VinagreSpinner by a GtkSpinner

(Note : I'm still a very beginner at GNOME development, be indulgent :-)
Comment 2 Stéphane Maniaci 2010-03-22 15:18:50 UTC 
Created attachment 156754 [details] [review]
Replace custom VinagreSpinner by a GtkSpinner

Previous patch was messy because I had edited some other files and edited the diff by hand. This one is clean.
Comment 3 Stéphane Maniaci 2010-04-08 08:15:13 UTC 
Created attachment 158177 [details] [review]
Replace custom VinagreSpinner by a GtkSpinner

Bumps GTK required version to 2.20.
Comment 4 Marcus Carlson 2010-04-14 17:52:20 UTC 
Comment on attachment 158177 [details] [review]
Replace custom VinagreSpinner by a GtkSpinner

I haven't tried this but is this really correct:??
+      spinner = gtk_spinner_new();
       spinner = g_object_get_data (G_OBJECT (nb->priv->active_tab), "spinner");

Looks like we're leaking...
Comment 5 Jonh Wendell 2010-06-05 14:39:41 UTC 
Thanks, Stéphane. I just changed the issue pointed by Marcus and committed your patch. Thanks also Marcus.