After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608095 - [ShellGlobal] Add shell_global_gc
[ShellGlobal] Add shell_global_gc
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 604075
Blocks:
 
 
Reported: 2010-01-25 21:45 UTC by Colin Walters
Modified: 2010-02-01 21:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[ShellGlobal] Add shell_global_gc (1.84 KB, patch)
2010-01-25 21:45 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2010-01-25 21:45:20 UTC
Primarily useful for debugging.  This was originally a patch against
gjs: https://bugzilla.gnome.org/show_bug.cgi?id=595323

But rather than add a random toplevel module just for this function
effectively, we can easily enough define it here.  Adding toplevel
modules to GScript should have a bit more formal process to it.
Comment 1 Colin Walters 2010-01-25 21:45:22 UTC
Created attachment 152267 [details] [review]
[ShellGlobal] Add shell_global_gc
Comment 2 Owen Taylor 2010-01-29 15:48:16 UTC
Review of attachment 152267 [details] [review]:

Patch looks obviously, fine but deps on an uncommitted GJS bug, so please don't commit despite me marking accepted-commit-now

::: src/shell-global.c
@@ +825,3 @@
+  JSContext *context = gjs_context_get_context (global->js_context);
+
+  JS_GC(context);

Missing space