After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608053 - gtk_notebook_set_tab_label_packing has been deprecated in GTK+ 2.20
gtk_notebook_set_tab_label_packing has been deprecated in GTK+ 2.20
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-01-25 17:51 UTC by Guillaume Desmottes
Modified: 2010-02-08 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
modifies tab-expand and tab-fill properties of child in chat-window (1.26 KB, patch)
2010-01-27 19:00 UTC, Reimundo Heluani
committed Details | Review

Description Guillaume Desmottes 2010-01-25 17:51:17 UTC
See http://library.gnome.org/devel/gtk/unstable/GtkNotebook.html#gtk-notebook-set-tab-label-packing

we should stop using it when switching to GTK+ 2.20.
Comment 1 Reimundo Heluani 2010-01-25 19:06:33 UTC
Does this work?

diff --git a/src/empathy-chat-window.c b/src/empathy-chat-window.c
index 801cf57..08a79d4 100644
--- a/src/empathy-chat-window.c
+++ b/src/empathy-chat-window.c
@@ -2068,8 +2068,9 @@ empathy_chat_window_add_chat (EmpathyChatWindow *window,
        gtk_notebook_append_page_menu (GTK_NOTEBOOK (priv->notebook), child, label, popup_label);
        gtk_notebook_set_tab_reorderable (GTK_NOTEBOOK (priv->notebook), child, TRUE);
        gtk_notebook_set_tab_detachable (GTK_NOTEBOOK (priv->notebook), child, TRUE);
-       gtk_notebook_set_tab_label_packing (GTK_NOTEBOOK (priv->notebook), child,
-                                           TRUE, TRUE, GTK_PACK_START);
+       gtk_container_child_set_property ( GTK_CONTAINER (priv->notebook), child, (gchar*) "tab-expand" , (GValue*) TRUE);
+
+       gtk_container_child_set_property ( GTK_CONTAINER (priv->notebook), child, (gchar*) "tab-fill" , (GValue*) TRUE);
 
        DEBUG ("Chat added (%d references)", G_OBJECT (chat)->ref_count);
 }
Comment 2 Reimundo Heluani 2010-01-27 17:25:45 UTC
Nope it doesn't... sorry about that patch
R.
Comment 3 Reimundo Heluani 2010-01-27 19:00:24 UTC
Created attachment 152441 [details] [review]
modifies tab-expand and tab-fill properties of child in chat-window
Comment 4 Guillaume Desmottes 2010-02-08 14:47:03 UTC
Thanks for your patch Reimundo. I fixed some minor still issues and merged it to master.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.