GNOME Bugzilla – Bug 607550
Add the possibility to hide the GtkHTML Edit toolbar
Last modified: 2021-05-19 11:44:58 UTC
Created attachment 151832 [details] [review] Proposed patch When composing a mail, the GtkHTML Edit toolbar is highly annoying for me ;-) - I write only plain-text mails, and the toolbar only wastes place on my screen. The attached patch adds the possibility to hide it, using the same menu as where From/To/CC/BCC can be hidden (View). Comments [or commit & push ;-)] appreciated.
This was originally posted to evolution-patches@gnome.org by Jan Holesovsky. I'm just reposting here.
I guess I'm not opposed to this, but there's a few things to consider: 1) I'd suggest implementing most of this directly in GtkhtmlEditor (except for the GConf binding), for reasons stated below. 2) The toolbar you're trying to hide is actually intended for plain-text mails. There's an additional edit toolbar with HTML-specific controls (Format->HTML to see it). The option should hide both toolbars, with the menu option saying "Edit Toolbars" (plural). 3) Easiest way to do that is to pack both the plain-text and HTML toolbars into a new GtkVBox and have the toggle action control the vbox visibility. The toolbar widgets get packed in gtkhtml-editor-private.c. 4) When adding the toggle action to gtkhtml-editor-manager.ui, we'll need a new placeholder in the View menu so Evolution can insert its header options in the correct spot. Would also be good to add a separator between the header options and the toolbar option. (This will also require changing evolution-composer.ui to use the new placeholder.) 5) Also on the Evolution side, you can bind the GConf key to the toggle action instead of the widget. I tend to prefer this anyway as it helps keep the relationships clear.
*** Bug 618502 has been marked as a duplicate of this bug. ***
Wondering if the WebKit rewrite makes this easier...
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/evolution/-/issues/ Thank you for your understanding and your help.