After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607007 - use of deprecated function cogl_clip_push()
use of deprecated function cogl_clip_push()
Status: RESOLVED DUPLICATE of bug 610679
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-01-14 19:58 UTC by Nickolas Lloyd
Modified: 2010-02-22 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove deprecated function (2.42 KB, patch)
2010-02-01 19:54 UTC, Luis Medinas
needs-work Details | Review

Description Nickolas Lloyd 2010-01-14 19:58:30 UTC
as of clutter version 1.2, the function cogl_clip_push() is deprecated.  because of the default use of -Werror, this of course causes a compilation error.  this 'bug' is present in the latest git version, and atm i don't know enough about the function and how it's used to write a patch.  it looks like it should be a fairly simple fix though.
Comment 1 Luis Medinas 2010-02-01 19:11:24 UTC
Pass this argument to ./configure --enable-compile-warnings so you can be able to compile it.
Comment 2 Luis Medinas 2010-02-01 19:54:29 UTC
Created attachment 152757 [details] [review]
Remove deprecated function

This patch uses the new function from clutter 1.2.
I didn't change the requirements to clutter 1.2 (cogl) because clutter 1.1.x doesn't have the API bump on .pc files.
Comment 3 Nickolas Lloyd 2010-02-01 20:48:52 UTC
patch works great, thanks!
Comment 4 Owen Taylor 2010-02-01 20:55:02 UTC
Reopening, nothing was resolved (we don't yet support compiling with clutter 1.1.x)
Comment 5 Colin Walters 2010-02-11 18:49:01 UTC
Review of attachment 152757 [details] [review]:

This patch needs to be part of a larger "Switch to clutter 1.2" patch, at a minimum patching the configure.ac and jhbuild moduleset.
Comment 6 Florian Müllner 2010-02-22 12:00:25 UTC
I'm closing this as a duplicate because according to the documentation [1], the use of cogl_clip_push_rectangle in the patch to bug 610679 is the correct one. Of course, Colin's comment still applies.


[1] http://clutter-project.org/docs/cogl/unstable/cogl-Clipping.html#cogl-clip-push-rectangle

*** This bug has been marked as a duplicate of bug 610679 ***