After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606665 - error: "__MSVCRT_VERSION__" redefined
error: "__MSVCRT_VERSION__" redefined
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal minor
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-11 19:46 UTC by LRN
Modified: 2010-01-12 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Include config.h before anything else. Fix mpegdemux LIBADD (4.59 KB, patch)
2010-01-11 19:47 UTC, LRN 		committed Details | Review

Description LRN 2010-01-11 19:46:28 UTC 
Some files (that were added since October, while my buildbot was dead) in -bad do include config.h after some system headers. This doesn't work well on Windows, because config.h defines much needed __MSVCRT_VERSION__ constant, which must be defined before system headers are included.

Also, there's a typo in mpegdemux Makefile.am

Patch coming soon.
Comment 1 LRN 2010-01-11 19:47:38 UTC 
Created attachment 151184 [details] [review]
Include config.h before anything else. Fix mpegdemux LIBADD
Comment 2 Sebastian Dröge (slomo) 2010-01-12 11:33:00 UTC 
commit b3f0b029f3c3382cf7d63c22f144e3204c68b182
Author: <D0><F3><F1><EB><E0><ED> <C8><E6><E1><F3><EB><E0><F2><EE><E2> <lrn1986@g
Date:   Mon Jan 11 22:41:57 2010 +0300

    win32: Include config.h before anything else. Fix mpegdemux LIBADD
    
    Because config.h defines __MSVCRT_VERSION__, which should be defined
    before inclusion of any system header.
    
    Also fixes mpegdemux Makefile.am LIBADD typo.
    
    Fixes #606665
Comment 3 Tim-Philipp Müller 2010-01-12 12:15:03 UTC 
> commit b3f0b029f3c3382cf7d63c22f144e3204c68b182
> Author: <D0><F3><F1><EB><E0><ED> <C8><E6><E1><F3><EB><E0><F2><EE><E2>
> <lrn1986

LRN: now, any chance you could use an UTF-8 environment/locale or somehow otherwise make sure we get your name in UTF-8 encoding? :-)
Comment 4 LRN 2010-01-12 13:01:10 UTC 
Ah, i've used vim to edit the config. I thought it uses utf8 by default. Apparently not :(